Add return_components support to R-learner#923
Conversation
jeongyoonlee
left a comment
There was a problem hiding this comment.
Two blockers before merge:
B1 — the p component is the stored training propensity, not recomputed for the passed X.
In both predict() bodies, when p is None you set p = self.propensity (training-data propensity) while yhat = self.model_mu.predict(X) is computed for the passed X. The two returned components end up on different bases, and on a differently-sized X the p array length won't match yhat/te — with no error raised:
rl.fit(X[:800], treatment[:800], y[:800], p=p[:800])
te, yhat, p_hat = rl.predict(X[800:1000], return_components=True)
# te: (200, 1), yhat: len 200, p_hat: len 800Please mirror the X-learner, which recomputes propensity for X (xlearner.py:203/:643):
if p is None:
p = {g: self.propensity_model[g].predict(X) for g in self.t_groups}
else:
p = self._format_p(p, self.t_groups)Note self.propensity_model only exists when fit() ran with p=None; if the user supplied p at fit and then calls predict(p=None) there is no model to recompute from — raise a clear error there rather than returning stale training values. The current test doesn't surface this because it always passes p=p_scores and predicts on the training X of equal length.
B2 — predict(..., return_ci=True) is accepted but never implemented.
The new predict() signature adds return_ci=False, but the body only uses it for the return_ci/return_components mutual-exclusion guard — it never computes CIs. So te, lb, ub = rl.predict(X, return_ci=True) raises ValueError at the unpack site (same footgun as #886). R-learner has no per-predict bootstrap path, so rather than accept-and-ignore, please drop return_ci from predict() (keep the guard in fit_predict, which does implement it) or raise NotImplementedError when True.
Tests: the new coverage only exercises BaseRLearner. Since BaseRClassifier and XGBRRegressor both had fit()/predict() modified, please add return_components tests for the classifier override and XGBR, plus the p=None predict path and a predict on a different-sized X (that last one guards B1).
Non-blocking notes to follow separately.
jeongyoonlee
left a comment
There was a problem hiding this comment.
One blocker:
predict(X) (with return_components off) now raises on a learner fit with an explicit p.
The nuisance computation was hoisted above the te-only early return, so p (and yhat) are computed on every predict() even when return_components=False. On master predict(X, p=None) never touches p — the CATE comes only from models_tau — so this is a regression:
rl = BaseRRegressor(learner=LinearRegression(), control_name="control")
rl.fit(X, treatment, y, p=p) # fit with explicit propensity
rl.predict(X) # master: returns te; this PR: ValueError: No propensity model is available.That's why get_synthetic_preds_holdout and three existing tests had to start passing p= to predict(). Please move the p/yhat computation inside if return_components: so the plain predict(X) → te path stays as on master (and skips the extra work):
te = np.zeros((n_rows(X), self.t_groups.shape[0]))
for i, group in enumerate(self.t_groups):
te[:, i] = self.models_tau[group].predict(X)
if not return_components:
return te
if p is None:
if not hasattr(self, "propensity_model"):
raise ValueError("No propensity model is available. ...")
p = {g: self.propensity_model[g].predict(X) for g in self.t_groups}
else:
p = self._format_p(p, self.t_groups)
yhat = self.model_mu.predict(X)
return te, yhat, pSame change in the BaseRClassifier override. With that, the p= additions in synthetic.py and the tests become unnecessary.
Non-blocking notes to follow separately.
d75f0a3 to
7288155
Compare
jeongyoonlee
left a comment
There was a problem hiding this comment.
LGTM.
One non-blocking follow-up: self.model_mu.fit(X, y_np) runs on every fit() even when return_components is never used — worth gating or lazy-fitting so the extra full-data fit only happens when the components are actually requested.
Proposed changes
this PR adds
return_componentssupport to the R-Learner, bringing its API in line with the existing T- and X-Learner implementationsspecific changes..
return_componentsargument topredict()andfit_predict()for bothBaseRLearnerandBaseRClassifieryhat: outcome model predictions (E[Y|X])p: propensity score estimates (E[W|X])return_ciandreturn_componentsfrom being used togetherreturn_componentsfunctionality for bothpredict()andfit_predict()along with the mutual exclusion behaviorfixes #304
Types of changes
What types of changes does your code introduce to CausalML?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.