Repository navigation
gen-atomicint: wrap sync/atomic types to ensure 64-bit alignment on 32-bit platforms - #219
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
|
|
…2-bit platforms On 32-bit architectures (ARM, 386, MIPS), 64-bit atomic operations require 8-byte memory alignment. In uber-go/atomic, Int64 and Duration embedded raw int64 values which have 4-byte alignment on 32-bit architectures, causing unaligned 64-bit atomic panics when embedded in structs. Update internal/gen-atomicint/wrapper.tmpl and generated types to wrap standard library sync/atomic typed atomic types (sync/atomic.Int64, sync/atomic.Uint64, etc.), which embed _ align64 to guarantee 8-byte alignment across 32-bit architectures. Fixes uber-go#105
AdamMagued
force-pushed
the
fix-64bit-alignment-32bit
branch
from
October 14, 2026 07:46
b5e7fc5 to
8df6829
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On 32-bit architectures (ARM, 386, MIPS), 64-bit atomic operations (
atomic.Store64,atomic.Load64, etc.) require 8-byte memory alignment. BecauseInt64andDurationpreviously embedded rawint64without 8-byte alignment padding or typed sync/atomic wrappers, embedding these types within larger structs on 32-bit architectures could result in a 4-byte aligned field offset, leading to:Changes
internal/gen-atomicint/wrapper.tmplto wrapsync/atomictyped atomic structs (sync/atomic.Int32,sync/atomic.Int64,sync/atomic.Uint32,sync/atomic.Uint64,sync/atomic.Uintptr). In Go 1.19+, standard librarysync/atomic.Int64andsync/atomic.Uint64embed_ align64, guaranteeing 8-byte memory alignment on 32-bit systems.int32.go,int64.go,uint32.go,uint64.go,uintptr.go, and wrapper types).Int64,Uint64,Float64, andDuration.Fixes #105