feat: integration story — close the systemic compose gap (unwired entry points + mock-only interfaces)#105
Merged
Merged
Conversation
…y points, mock-only interfaces) Per-story unit tests pass against mocks, but the whole app never has to compose: handlers built but never registered in main, auth middleware never applied, interfaces that only a test mock satisfies. shiftsync reached REQ_COMPLETED with 3 of 5 endpoints 404 and no auth. Planner now appends a final 'integrate' story (before scribe, depends on all code stories) that: wires every component into the real entry point, applies cross- cutting middleware, bridges interface mismatches with adapters (real impls, not mocks), and writes an end-to-end SMOKE TEST that boots the app and asserts the documented surface responds (protected routes reject missing creds, endpoints don't 404). The smoke test runs in QA / the pre-merge gate, so a non-functional whole fails the build instead of 'completing'. Gated by planning.emit_integration_story (default on). Enabled by the edge-aware overlap fix, which lets the sequenced integration story co-edit the skeleton-owned entry point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
Per-story unit tests pass against mocks, but the whole app never has to compose. shiftsync reached REQ_COMPLETED with 3 of 5 endpoints returning 404, no auth applied, and
shift.Validatorsatisfiable only by a test mock. Green tests masked a non-functional app — the dangling-wire + interface-mismatch class.The fix
The planner now appends a final integration story (before the scribe, depends on every code story) instructed to:
The smoke test runs in QA / the pre-merge gate, so a non-functional whole fails the build instead of completing. Gated by
planning.emit_integration_story(default on). Enabled by the edge-aware overlap fix (#101) — the sequenced integration story can co-edit the skeleton-owned entry point.Test plan
go test ./...green (31 pkgs; codegraph is env-only). NewTestPlanner_EmitsIntegrationStory; count-sensitive tests updated.🤖 Generated with Claude Code