Scope ServiceVerbTests to a fixture-local GVFS service - #7
Closed
tyrielv wants to merge 1 commit into
Closed
Conversation
Run ServiceVerbTests against a dedicated GVFS service name so --mount-all/--unmount-all only touch repos created in that fixture.\n\nThis wires service-name overrides through functional-test helpers and adds fixture-local service lifecycle setup/teardown for ServiceVerbTests. Assisted-by: GPT-5.3-Codex\nSigned-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/test-registry-scoping
branch
from
July 10, 2026 17:34
ff4555c to
47683e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- run ServiceVerbTests against a dedicated service name per fixture instance instead of the shared test service\n- thread optional service-name overrides through GVFSHelpers, GVFSProcess, and GVFSFunctionalTestEnlistment so clone/mount/unmount/register/service verbs all hit the same fixture-local registry\n- add overloads in GVFSServiceProcess to install/start/stop/uninstall a named test service while keeping existing defaults intact\n\n## Validation\n- dotnet build GVFS/GVFS.FunctionalTests/GVFS.FunctionalTests.csproj -c Debug\n- attempted targeted functional test run of ServiceVerbTests.ServiceCommandsWithNoRepos (blocked locally by existing ProgramData access denial while cleaning Test.GVFS.Service logs before tests start)