Repository navigation
Remove LDCodecWithInfallibleEncode - #248
Open
morgen-peschke wants to merge 7 commits into
Open
morgen-peschke wants to merge 7 commits into
morgen-peschke wants to merge 7 commits into
Conversation
We're papering over something that probably shouldn't be papered over, and it makes the whole thing messy. Much better to be open about LDValue's inability to encode certain values, and keep the type hierarchy clean.
rossabaker
approved these changes
Oct 5, 2026
rossabaker
left a comment
rossabaker
left a comment
Member
There was a problem hiding this comment.
or die is giving me Perl flashbacks.
Really not sure why this wasn't deleted before, it wasn't showing in my editor, so I'm guessing some sort of odd IntelliJ bug?
- Fix a Scala 3 thing that was making the tests mad - Made LDCursor a bit easier to work with
rossabaker
approved these changes
Oct 6, 2026
Contributor
Author
I've always been fond of that wording 😁 |
zarthross
requested changes
Oct 8, 2026
zarthross
left a comment
zarthross
left a comment
Contributor
There was a problem hiding this comment.
I think the naming can be fixed on the 'orDie', usually we use 'unsafe' as the vocabulary for those types of methods right?
zarthross
approved these changes
Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're papering over something that probably shouldn't be papered over, and it makes the whole thing messy.
Much better to be open about
LDValue's inability to encode certain values, and keep the type hierarchy clean.