Repository navigation
feat: run the publisher chart on a schedule - #50
Conversation
Setting `schedule` renders a CronJob, `<network>-publisher`, in place of the one-shot Job. Each run is `stelae-publisher run` on the kept claim, with `concurrencyPolicy: Forbid` so a run never starts beside one still in flight. The pod template moves into a shared helper, so the Job renders as before. `run` is required only without a schedule, and a schedule without a persistent claim fails the render. Bumps the chart to 0.5.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…689d98b08d4f152862a43b037f199
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
QA review record
QA counts: pass=later size=small lenses=1 confirmed=0 blocking=0 fixed-by-qa=0 backlog=3 plausible=0 refuted=0 unrefuted=3 |
Render startingDeadlineSeconds and the history limits only when set, so a null value no longer renders 0. Document moving a scheduled release back to the one-shot Job, and the Kubernetes version Forbid needs for one writer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Set podReplacementPolicy: Failed on the CronJob's job template, so a replacement pod waits for the one it replaces to terminate. State Kubernetes 1.31 as a requirement of the schedule instead of advice for older clusters, which could not prevent a second writer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Job and CronJob now render one pod template, so the credential-name check reads it there and confirms both workloads include it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge observed. Plan: Trellis will verify the human merge evidence, adopt the domain pin, and retire the plan. No further merge action is needed. |
Lets an operator run the publisher chart on a schedule instead of as a one-shot Job.
What changes
schedulevalue. Set, the chart renders a CronJob<network>-publisherin place of the Job. Each run isstelae-publisher runon the kept claim, withconcurrencyPolicy: Forbid, so a run never starts beside one still in flight.suspend,startingDeadlineSeconds(3600),successfulJobsHistoryLimit/failedJobsHistoryLimit(3 each) and an optionalactiveDeadlineSecondsare values;backoffLimitis shared with the Job.dolos-publisher.podTemplatehelper used by both. Without a schedule the rendered manifests are unchanged apart from the chart version label.runis required only without a schedule. A schedule withoutpersistence.enabledfails the render, since every run on an emptyDir would restore all of history.NOTES.txtnames the CronJob and how to follow its latest run. The chart README gets a "Scheduled runs" section (runs with nothing to publish,Forbidas the single-writer guarantee and manual Jobs,backoffLimitand failure, moving from the one-shot Job, how changes take effect).docs/publisher-packaging.mdmentions the scheduled form.0.5.0.Checks
k8s/dolos-publisher/test.shextended for: no schedule (Job, no CronJob), schedule (CronJob named<network>-publisher,Forbid, claim at/data, same container args as the Job, no Job), schedule withoutrun, no schedule withoutrun(fails), schedule with persistence off (fails),suspend: true.helm lintwithtests/values.yaml, with and without a schedule.helm templatewithtests/values.yamlbefore and after: only thehelm.sh/chartlabel differs.🤖 Generated with Claude Code