Skip to content

feat: publish the Helm charts as OCI packages on release - #49

Merged
scarmuega merged 5 commits into
mainfrom
work/work-dfd8e3b37d3f0d327219504262900b1172e8808e
Nov 21, 2026
Merged

scarmuega merged 5 commits into
mainfrom
work/work-dfd8e3b37d3f0d327219504262900b1172e8808e

Conversation

@scarmuega

@scarmuega scarmuega commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

A release now publishes both Helm charts as OCI packages, so an operator can deploy a pinned chart version without a checkout.

  • k8s/package-charts.sh <out-dir> packages dolos-publisher and stelae-registry at each chart's own version:.
  • k8s/push-charts.sh <out-dir> pushes each package to oci://ghcr.io/txpipe/charts/<name>. It skips a version the registry already holds and stops if it can't tell whether a version exists, so it never replaces a published version.
  • k8s/check-chart-versions.sh <base-ref> fails for a chart whose files changed since <base-ref> while its version did not.
  • Workflow: the chart job now packages the charts and runs both shell tests (the version check in a throwaway repo, the push against a local registry). On pull requests it also runs the version check against the newest v* tag on the base branch. On a v* tag, a new charts job logs in to GHCR with the workflow token and pushes. Its permissions are contents: read (for checkout) and packages: write.
  • Docs: the "Release" section of docs/publisher-packaging.md and each chart README now cover the packages and how to pull them.

This PR pushes no package.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Dolos Publisher and Stelae Registry Helm charts are now published as OCI packages alongside image releases.
    • Published chart versions are preserved; releases skip chart versions already available in the registry.
    • Chart changes are checked for a version bump before publication.
  • Documentation
    • Added instructions for pulling pinned chart versions with Helm.
    • Documented that newly published chart packages are private until made public by the organization owner.

A version tag now packages both charts and pushes each to
oci://ghcr.io/txpipe/charts/<name> at its own chart version, skipping any
version the registry already holds. Pull requests package the charts and
fail when a chart changed since the newest release tag without a version
bump. Shell tests cover the version check in a throwaway repository and the
push against a local registry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The PR adds chart version checks, Helm chart packaging, and OCI publication to the release workflow. It adds tests for version checks and local-registry publishing, and documents how to publish and retrieve chart versions.

Changes: Chart Release

Layer / File(s) Summary
Chart version validation
k8s/check-chart-versions.sh, k8s/previous-release-tag.sh, k8s/check-chart-versions.test.sh
The scripts check chart version changes against a base reference and locate the next release tag. Tests cover unchanged charts, missing version bumps, and release-tag lookup, including a release whose commit was squashed onto the main branch.
Chart packaging and publication
k8s/package-charts.sh, k8s/push-charts.sh, k8s/push-charts.test.sh, .github/workflows/publisher-release.yml, docs/publisher-packaging.md, k8s/dolos-publisher/README.md, k8s/registry/README.md
The workflow runs chart checks and adds a tag-triggered job to package charts and publish chart versions that are not already in GHCR. The local-registry test checks first publication and repeat-push behavior. The documentation describes release publication and pinned chart retrieval.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant ReleaseWorkflow
  participant VersionChecks
  participant ChartScripts
  participant GHCR
  ReleaseWorkflow->>VersionChecks: Check chart versions against release tags
  ReleaseWorkflow->>ChartScripts: Package Helm charts
  ChartScripts->>GHCR: Check whether chart versions exist
  ChartScripts->>GHCR: Push chart versions not found
Loading

Possibly related PRs

  • txpipe/stelae#48: Updates the registry chart version that the packaging and version-check scripts read from Chart.yaml.
Merge Risk: Low · up to 5e3c3

The release automation packages and publishes both Helm charts as intended and skips versions that already exist. A few narrow edge cases could let a changed chart go unpublished or a published version be replaced: version downgrades, squash-merged releases, a missing layer blob, and overlapping publish runs. These are unlikely and can be fixed in follow-up changes, so the PR is mergeable with awareness of them.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@scarmuega

scarmuega commented Nov 21, 2026 •

Copy link
Copy Markdown
Member Author

QA review record

  • Outcome: passed at head 5e3c317 (later pass: a base sync that merges main at 0e68dd3, feat: let the registry chart render a writer that cannot delete #48, into 5e19e68. The rework diff, leaving out the merged target changes, is the one-hunk conflict resolution, size small).
  • Resolution: both sides are kept. git diff 0e68dd3 5e3c317 is exactly this PR's original workflow, script and docs additions. git diff 5e19e68 5e3c317 is exactly main's changes, including the k8s/registry/test.sh step. Nothing else changed.
  • Contract check against main: the registry chart is now stelae-registry 0.2.0. The PR's scripts read the name and version from Chart.yaml, so they pick it up. The README pull command and the docs name stelae-registry, and the version check passes, because main bumped the version along with its chart change.
  • Previous findings: none open. The pass-3 lows stay in the QA backlog. New findings: none.
  • Checks at head: Publisher chart passes. It runs both chart tests, packages dolos-publisher 0.4.0 and stelae-registry 0.2.0, runs the version-check test and the push test (publish, then skip), and runs the PR version check. Clippy, fmt, cargo deny, the three registry round trips, fault parity, both image builds and stelae-blocks without hardano also pass. Publish charts and the image publish are skipped, so the PR pushed nothing. The two Test jobs were still pending when this was recorded; this PR changes no Rust code.
  • PR comments: CodeRabbit skipped the draft. There are no human comments.
  • Lenses: one combined reviewer on the resolution (correctness, state, conformance with both sides). No refuter was needed. Independence was degraded: the resolution adds nothing, so it was checked in the QA session rather than in a fresh context.

QA counts: pass=later size=small lenses=1 confirmed=0 blocking=0 fixed-by-qa=0 backlog=0 plausible=0 refuted=0 unrefuted=0
QA lenses: combined=0/0/0

scarmuega and others added 2 commits November 21, 2026 13:58
The release recheck used `git describe HEAD^`, which skips a release
tagged on a commit the branch does not reach, such as one squash-merged
through a release PR. k8s/previous-release-tag.sh picks the highest v*
tag below the one being released, and the chart version test covers a
release tagged off the branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@scarmuega

scarmuega commented Nov 21, 2026 •

Copy link
Copy Markdown
Member Author

Merge observed.

Plan: plans/stelae-scheduled-publishing-chart-packages.md
QA-approved head: 5e3c317221a0e6310dd74d410962c076686f420d

Trellis will verify the human merge evidence, adopt the domain pin, and retire the plan. No further merge action is needed.

@scarmuega
scarmuega marked this pull request as ready for review November 21, 2026 17:23
@scarmuega
scarmuega marked this pull request as draft November 21, 2026 19:42
…f0d327219504262900b1172e8808e

# Conflicts:
#	.github/workflows/publisher-release.yml
@scarmuega
scarmuega marked this pull request as ready for review November 21, 2026 19:55
@scarmuega
scarmuega merged commit 190c69c into main Nov 21, 2026
15 of 16 checks passed
@scarmuega
scarmuega deleted the work/work-dfd8e3b37d3f0d327219504262900b1172e8808e branch November 21, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant