Repository navigation
Preserve an explicit log selection during startup - #1755
Merged
Merged
Conversation
Owner
|
Seems to work, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial
-c ':goto 2'command selects the requested log row, but startup then callsset_top_for_last_row(), which moves that selection into the bottom viewport before session restoration. Only apply the default scroll when the log view has no explicit selection, matching the precedence already used byrestore_view_states().Adds real-terminal regressions for the default position, initial goto, saved-position restoration, and a new goto overriding the saved position. A replay-only option in the test helper allows these assertions to inspect the resulting selection without comparing transient screen redraws; child failures still fail the test.
Validation: the new initial-goto regression fails with the original binary and all four scenarios pass with this change.
make -j4 checkreports 53/56 passing on Linux arm64, including command, session, and TUI suites. The three failing suites (test_logfile.sh,test_sql_indexes.sh,test_log2src.sh) also fail with the original binary; they show stdin/timezone golden differences, SQL ordering/query-plan differences, and log2src schema/output differences respectively. Existing TUI snapshot diagnostics also occur on the original binary and are informational in the upstream harness. macOS and Windows were not tested.Addresses the command-navigation part of #1741. This does not add file-specific
file:linenavigation to the merged log view.Implemented and validated with OpenAI Codex.