Add explicit fanout boundary positions - #812
Conversation
|
Coordinated implementation: fanout-solver tscircuit/fanout-solver#91 and downstream Core draft tscircuit/core#3411. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| test("autorouting phase rejects low-level solver boundary-region names", () => { | ||
| expect(() => | ||
| autoroutingPhaseProps.parse({ | ||
| autorouter: "fanout", | ||
| busFanoutDirections: { DATA: "right_top" }, | ||
| }), | ||
| ).toThrow() | ||
| }) |
There was a problem hiding this comment.
A *.test.ts file may have AT MOST one test(...) call. The file tests/autoroutingphase.test.ts already contained multiple test(...) blocks before this PR, and this diff adds yet another one ("autorouting phase rejects low-level solver boundary-region names"). Each additional test beyond the first should be placed in a separate, numbered file — for example autoroutingphase2.test.ts, autoroutingphase3.test.ts, etc. Please move this new test (and any others beyond the first) into their own numbered test files.
Spotted by Graphite (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
|
NinePointAnchor compatibility is explicitly additive. This follow-up exhaustively covers all nine legacy values in scalar and object forms, restores the existing legacy parser examples, and documents that they remain unchanged and destination-guided. |
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
2 participants
Summary
Why
Corner names such as top_right were ambiguous: they could mean a top-edge exit near the right or a right-edge exit near the top. The new values make the physical boundary explicit without widening the generic NinePointAnchor type used by unrelated layout APIs.
Testing