Repository navigation
fix: escape HTML in admin pages and sandbox static file responses - #181
Open
huangji6693-max wants to merge 1 commit into
Open
huangji6693-max wants to merge 1 commit into
huangji6693-max wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #175
/claim #175
Summary
escapeHtmlhelper inlib/utils/escape-html.tsand escape dynamic values (file_path,file_id,created_at,event_type, serialized event details, andtext_content) across/admin/files/list,/admin/files/get, and/admin/events/listto prevent stored XSS.Content-Security-Policy: sandboxandX-Content-Type-Options: nosniffresponse headers on/files/static/[[...file_path]]so uploaded active content cannot execute scripts in the server origin.tests/routes/admin-files-page.test.ts.Verification
bun test(30 pass, 0 fail)bun run format:check(0 errors)Payout Wallets
0x380C97bcbcAEf29DAc2d0ba7E180F1b4A7F38fddGBYWLISGOUWQ43VQEGXX6KRGDZ3CKAFFK3JXVLXKDO5TIFJUJ3OHJYOZAyXYaA9Nf4z5fpLKY6DmubWe6D2qveMd79w8pEDNHcDw