Repository navigation
Conversation
… groups) normalizePath used /\/\/+/ (single match per pass) so '///a//b' normalized to '/ /a/b'-style leftovers and was not idempotent; path-form download routes joined route segments and then relied on getFile's normalizePath, so requests with repeated slashes missed stored files. Use /\/\/+/g globally and add download endpoint tests (query form, path form, binary bytes/content-length, 404, idempotence) covering issue tscircuit#5 deliverables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #5
Following the /attempt #5 plan. The download endpoints (query form + path form) already exist on main; the remaining defect that breaks reliable downloads is
normalizePathmissing the global flag on its slash-collapse regex, so repeated slash groups beyond the first survive and the function is not idempotent — route-joined path segments then fail to match stored files.Changes:
/files/download?...as well as/files/download/[[file_path]]#5 deliverables: normalizePath idempotence (incl. 4+ slash groups), query-form text download with Content-Disposition, path-form deep download, binary bytes exactness + Content-Length + octet-stream, 404 body for unknown file, path-form matching with leading-slash storage