Forward schematic pin-label font size to Circuit JSON - #3430
Open
GokulPandi-M wants to merge 2 commits into
Open
Forward schematic pin-label font size to Circuit JSON#3430GokulPandi-M wants to merge 2 commits into
GokulPandi-M wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
GokulPandi-M
marked this pull request as ready for review
August 25, 2026 19:08
seveibar
approved these changes
Aug 25, 2026
Contributor
|
don't submit for review until CI passes! |
Contributor
Author
yeap !! but this pr denpends on tscircuit/circuit-json#723 (so it is failing btw sorry for confusions) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carries the optional per-port
schPinLabelFontSizeprop intoschematic_port.display_pin_label_font_sizeas a precise numeric Circuit JSON value.Core resolves:
"sm"to0.12"0.1mm"(already normalized by props) to0.1"default"and omitted values toundefined, preserving the existing context-sensitive renderer defaultDependencies
circuit-json@0.0.476)Scope
This PR only resolves the props-level input and writes the precise optional value into Circuit JSON. Renderer support belongs in a separate circuit-to-svg PR.
Validation