fix: report source_component_misconfigured_error on empty connections target - #3428
Open
moxiaoshen567 wants to merge 1 commit into
Open
fix: report source_component_misconfigured_error on empty connections target#3428moxiaoshen567 wants to merge 1 commit into
moxiaoshen567 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2865
Summary
_createTracesFromConnectionsProp()(NormalComponent.ts).source_component_misconfigured_errorintocircuit.dbrather than letting empty selectors reachcss-whatand throw a raw parser error that crashes the entire render.tests/components/normal-components/connections-empty-string.test.tsxverifying the error is logged and valid sibling connections/traces still render.Verification
/claim #2865
💰 Payout Details
6UvBhyhY6ayeoJEGZxK4bDoFAHd9yeRDTVusnoDGdgQ5TYcNrMSoY36q8WrsFSZyB26Rkj25EFgQsX