Skip to content

Reproduce reused copper-pour bounds between breakouts - #3396

Open
ShiboSoftwareDev wants to merge 1 commit into
mainfrom
repro/active-breakout-copper-pour-bounds
Open

Reproduce reused copper-pour bounds between breakouts#3396
ShiboSoftwareDev wants to merge 1 commit into
mainfrom
repro/active-breakout-copper-pour-bounds

Conversation

@ShiboSoftwareDev

Copy link
Copy Markdown
Contributor

Summary

  • add an exact two-breakout regression fixture for outline-less, unbroken copper pours
  • record the Simple Route JSON received by each real custom breakout autorouter
  • demonstrate that the second breakout incorrectly receives the first breakout's 8mm x 8mm pour bounds
  • assert that both phases otherwise retain the same non-pour obstacle scope and that the second phase retains the first phase's routed traces

Why this repro is needed

A board subcircuit can contain several custom breakout routing groups. The board-level copper pours belong to every phase, but an outline-less pour must be represented using the bounds of the breakout that is currently routing. Core currently builds the board SRJ once, selecting the first matching PCB group, and both breakout phases reuse those pour obstacles. That gives the right-hand autorouter a false copper plane at the left-hand breakout and no copper plane where its real breakout sits.

The test uses the real phased-routing handoff rather than calling the SRJ utility in isolation, because the bug depends on how Core constructs and filters phase inputs. It intentionally leaves the failing coordinates in the repro commit. The stacked fix changes only the second breakout's expected center from x = -10 to x = 10; the non-pour obstacle and prior-trace assertions stay unchanged.

This is a stacked, test-first alternative to #3389. #3389 currently performs its substitution only in the connection-reroute branch, which does not execute for this ordinary custom-breakout fixture.

Test plan

  • bun test tests/breakout/active-breakout-copper-pour-bounds.test.tsx

Stacked fix: base the follow-up PR on this branch.

@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Aug 24, 2026 4:38am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant