Reproduce reused copper-pour bounds between breakouts - #3396
Open
ShiboSoftwareDev wants to merge 1 commit into
Open
Reproduce reused copper-pour bounds between breakouts#3396ShiboSoftwareDev wants to merge 1 commit into
ShiboSoftwareDev wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8mm x 8mmpour boundsWhy this repro is needed
A board subcircuit can contain several custom breakout routing groups. The board-level copper pours belong to every phase, but an outline-less pour must be represented using the bounds of the breakout that is currently routing. Core currently builds the board SRJ once, selecting the first matching PCB group, and both breakout phases reuse those pour obstacles. That gives the right-hand autorouter a false copper plane at the left-hand breakout and no copper plane where its real breakout sits.
The test uses the real phased-routing handoff rather than calling the SRJ utility in isolation, because the bug depends on how Core constructs and filters phase inputs. It intentionally leaves the failing coordinates in the repro commit. The stacked fix changes only the second breakout's expected center from
x = -10tox = 10; the non-pour obstacle and prior-trace assertions stay unchanged.This is a stacked, test-first alternative to #3389. #3389 currently performs its substitution only in the connection-reroute branch, which does not execute for this ordinary custom-breakout fixture.
Test plan
bun test tests/breakout/active-breakout-copper-pour-bounds.test.tsxStacked fix: base the follow-up PR on this branch.