Skip to content

feat: add implicit copper pour render phase - #3362

Draft
imrishabh18 wants to merge 4 commits into
mainfrom
agent/implicit-copper-pour-phase
Draft

feat: add implicit copper pour render phase#3362
imrishabh18 wants to merge 4 commits into
mainfrom
agent/implicit-copper-pour-phase

Conversation

@imrishabh18

@imrishabh18 imrishabh18 commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

  • pin implicit-copper-pour-solver#8 at commit 47f9301
  • use copper-pour-solver#85 so implicit clipping outlines can carry the physical PCB boundary separately
  • run PcbImplicitCopperPourRender after routing and before PcbCopperPourRender
  • convert each coarse implicit power-net region into a CopperPour component outline instead of inserting it as final Circuit JSON
  • apply zero clearance where same-net implicit regions touch while preserving clearance at the physical board edge, different nets, traces, pads, and cutouts
  • let the exact copper-pour solver compute the final BRep geometry and trace/component clearances
  • make PCB DRC wait for both copper-pour phases
  • keep the new phase behind _featureImplicitCopperPours during the initial rollout so existing circuits remain unchanged
  • update the nRF52810 regression, enable the feature there, and assert that all generated pours are final brep shapes

Testing

  • ./node_modules/.bin/tsc --noEmit
  • bun run build
  • bun run smoke-test:dist
  • bun test tests/repros/repro-nrf52810-without-copper-pours/repro-nrf52810-without-copper-pours.test.tsx
  • bun test tests/examples/example29-copper-pour.test.tsx tests/components/primitive-components/copperpour-thermal-reliefs.test.tsx tests/examples/example37-copper-pour-solver-emit.test.tsx
  • visual inspection of the regenerated top and bottom nRF snapshots
  • copper-pour-solver PR now supports fabrication note path/text color prop #85: all 49 tests, type-check, build, and CI checks pass

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Aug 25, 2026 11:50am

Request Review

@github-actions

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant