Skip to content

fix: allow components over owned cutouts - #259

Merged
MustafaMulla29 merged 4 commits into
mainfrom
fix/ignore-owned-component-cutouts
Sep 4, 2026
Merged

fix: allow components over owned cutouts#259
MustafaMulla29 merged 4 commits into
mainfrom
fix/ignore-owned-component-cutouts

Conversation

@MustafaMulla29

@MustafaMulla29 MustafaMulla29 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • ignore component-over-cutout placement errors when the cutout belongs to that same PCB component
  • add a focused regression test asserting no placement errors for a component over its own footprint cutout

Depends on tscircuit/circuit-json#745. Complements tscircuit/core#3628, which emits the cutout ownership field.

Testing

  • bun test tests/lib/check-pcb-component-over-cutout-owned.test.ts --no-orphans
  • bun run build

@MustafaMulla29
MustafaMulla29 merged commit 60ac3d1 into main Sep 4, 2026
5 checks passed
@MustafaMulla29
MustafaMulla29 deleted the fix/ignore-owned-component-cutouts branch September 4, 2026 09:14
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants