fix: allow edge-contact copper for off-board components - #235
Draft
KrishnaX12 wants to merge 1 commit into
Draft
Conversation
Author
Visual & Snapshot Verification
|
KrishnaX12
marked this pull request as draft
August 24, 2026 12:01
KrishnaX12
force-pushed
the
fix/allow-off-board-edge-contact-clearance
branch
from
August 25, 2026 13:03
24d81e7 to
ae7487e
Compare
KrishnaX12
force-pushed
the
fix/allow-off-board-edge-contact-clearance
branch
from
August 25, 2026 13:15
ae7487e to
c7f5eb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #228 by skipping the copper-to-board-edge clearance check for copper elements (SMT pads and plated holes) belonging to components marked
allowOffBoard(is_allowed_to_be_off_board: true).Problem
An SMT pad or component intentionally placed at or over the board boundary (such as an edge contact / finger jumper) was reported as violating the copper-to-board-edge clearance rule because
checkCopperToBoardEdgeClearancedid not checkis_allowed_to_be_off_boardon the owningpcb_component.Solution
lib/check-copper-to-board-edge-clearance.ts, collect component IDs withis_allowed_to_be_off_board === true.pcb_smtpad,pcb_plated_hole) whosepcb_component_idmatches an allowed off-board component.tests/repros/repro-edge-contact-pad-clearance.test.tsxfromtest.failingtotestwith an inline snapshot assertionexpect(errors).toMatchInlineSnapshot("[]").Verification
bun test tests/repros/repro-edge-contact-pad-clearance.test.tsxpassesbun testpasses (183 pass, 0 fail across 81 files)bun run formatandbun run buildpass cleanly