Fix false-positive unlocks: gate unlock on smoothed RSSI + minimum sample count#183
Open
7onnie wants to merge 3 commits into
Open
Fix false-positive unlocks: gate unlock on smoothed RSSI + minimum sample count#1837onnie wants to merge 3 commits into
7onnie wants to merge 3 commits into
Conversation
added 3 commits
June 18, 2026 22:48
…ike false positives The presence/unlock transition previously used a single raw RSSI reading, so one spurious strong sample (multipath reflection, advertising burst) could unlock the Mac from far away. Compute the moving average first and gate the transition on it plus a minimum sample count; drop the buffer-clearing that destabilised the lock decision. Refs ts1#153.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence/unlock transition used a single raw RSSI sample, so one spurious strong reading (multipath reflection, advertising burst) could unlock the Mac from across the home. This computes the moving average first and gates the unlock on it plus a minimum sample count, and removes the buffer-clearing that destabilised the lock decision. Pure logic is covered by standalone tests in Tests/. Refs #153.