fix(tasks): unref the pi-tasks detection timer so pi -p can exit - #122
Merged
Merged
Conversation
Without pi-tasks installed nothing answers the detection ping, so the 5s window timer kept one-shot pi -p processes alive ~4s after the response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkTasksVersion()opens a 5 s window listening for a pi-tasks reply to its detection ping. When pi-tasks isn't installed, nothing replies, and because the timer wasn'tunref'd, the full window kept one-shotpi -pprocesses running about 4 s after the response was printed.This PR unrefs that timer, the same way the monitor retention timers and the session heartbeat are already unref'd. Interactive sessions are unaffected: the event loop stays alive there, so the detection window still settles after 5 s as before.
Measurements
pi -p "say ok" --no-extensions -e <pi-loop>, without pi-tasks:Tests
unrefs the detection timer (so pi -p can exit). It fails without the fix.vitest run: 1067 passed. Typecheck passes. Lint shows no new warnings (the 2 existing ones are inmonitor-manager.ts).