Skip to content

Update trunk.yaml: Rust and Ruby toolchain improvements#1113

Merged
trunk-io[bot] merged 2 commits into
mainfrom
update-trunk-yaml-rust-ruby
Jun 4, 2026
Merged

Update trunk.yaml: Rust and Ruby toolchain improvements#1113
trunk-io[bot] merged 2 commits into
mainfrom
update-trunk-yaml-rust-ruby

Conversation

@dfrankland
Copy link
Copy Markdown
Member

@dfrankland dfrankland commented Jun 3, 2026

Summary

Stacked on #1112.

  • Rust: Switch from hermetic nightly download to SYSTEM, with cargo-fmt/clippy using run_when: [cli] so they're skipped in CI (CI uses prepare-rs/action.yaml directly instead)
  • Ruby: Switch from ruby-build (compiles from source, slow) to jdx/ruby pre-built binaries via the fake ruby-build wrapper added in Add fake ruby-build wrapper for jdx/ruby #1112; bumps Ruby 3.1.4 → 4.0.5
  • rubocop: Bump 1.39.0 → 1.87.0 alongside the Ruby upgrade
  • Everything else: Bump all linter/tool versions to latest

Test plan

  • trunk tools install --verbose completes with no failures
  • trunk check runs rubocop successfully on Ruby files
  • Rust linters (clippy, cargo-fmt) work locally

🤖 Generated with Claude Code

@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io Bot commented Jun 3, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
variant_quarantine_test should be quarantined when run with variant A test expected the sum of 2 + 2 to be 5, but it was actually 4, indicating a failing assertion. Logs ↗︎

View Full Report ↗︎Docs

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.40%. Comparing base (9ed5b45) to head (58fb4c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
+ Coverage   82.14%   82.40%   +0.25%     
==========================================
  Files          69       69              
  Lines       15243    15243              
==========================================
+ Hits        12522    12561      +39     
+ Misses       2721     2682      -39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Jun 3, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@TylerJang27
Copy link
Copy Markdown
Collaborator

Noting the failing TS stuff

@dfrankland dfrankland changed the base branch from add-ruby-build-tarball to main June 4, 2026 18:07
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Jun 4, 2026

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

dfrankland and others added 2 commits June 4, 2026 11:08
- Switch Rust from hermetic nightly download to SYSTEM, using
  cargo-fmt/clippy with run_when: [cli] to skip in CI (handled by
  prepare-rs/action.yaml instead)
- Switch Ruby from ruby-build (compiles from source) to jdx/ruby
  pre-built binaries via a fake ruby-build wrapper
- Bump rubocop 1.39.0 → 1.87.0 alongside Ruby 3.1.4 → 4.0.5
- Bump all other linter/tool versions to latest

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dfrankland dfrankland force-pushed the update-trunk-yaml-rust-ruby branch from 6bf91bb to 58fb4c9 Compare June 4, 2026 18:18
@trunk-io trunk-io Bot merged commit 6a65cdb into main Jun 4, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants