refactor: modernize tooling, tests and metadata - #197
Open
trueberryless-bot wants to merge 2 commits into
Open
trueberryless-bot wants to merge 2 commits into
trueberryless-bot wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
✅ Deploy Preview for felixs-homepage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the site in line with the shared setup from template-files. The design is untouched.
Changes
@atproto/lex0.3.13,@lucide/astro1.48, sharp 0.35.5, Prettier 3.9.9,prettier-plugin-astro1.1,fontless0.4 → 1.2 (the fonts still build), TypeScript 6 (not 7), pnpm 11.28.0, Node 24+ and"type": "module".pnpm buildsucceeds.package.json:name,bugsandrepositorystill pointed totrueberryless-org/trueberryless. They now usefelixs.devandtrueberryless/felixs.devfrom the shared template.astro check(pnpm check). The four errors it found are fixed:fragmentLabelcould call.replaceonundefined,SkillChipstyped its map key as nullable, and the projectCarddid not acceptnulldescriptions orlanguage.astro/tsconfigs/strictestreports 105 more errors (mostly indexed access), so I keptstrictand dropped the unused React JSX settings.felixs-devpreset, 👋) and its emoji asfavicon.svg, plusog:site_nameand the image size and alt text.aria-hidden..astro), knip, and the shared workflows,.gitignore,.prettierignoreandLICENSE. Removed the unused exports that knip found.cache.ts,posts.tsandbuildReadingSummary(100 % coverage ofcache.tsandposts.ts), and 34 Playwright tests on desktop and mobile against the built node server: headings and titles of every page, the 404 page, canonical and OG metadata, no horizontal overflow, and axe checks in both color schemes.Not covered
data.ts(863 lines of GitHub and ATproto fetching) has no tests and is excluded from coverage. The end-to-end tests only assert what does not depend on that data, because the server islands fetch it at request time. Mocking that layer is a good follow-up.no-map-spreadwarnings.trueberryless.orgfor the page speed check. It now usesfelixs.dev.Verified
astro check, oxlint, Prettier, knip,vitest --coverageand the 34 Playwright tests pass locally.🤖 Generated with Claude Code