Skip to content

feat: Add config-manager push cors command#90

Open
dallinjsevy wants to merge 1 commit into
mainfrom
feature/config-manager-push-cors
Open

feat: Add config-manager push cors command#90
dallinjsevy wants to merge 1 commit into
mainfrom
feature/config-manager-push-cors

Conversation

@dallinjsevy

Copy link
Copy Markdown

No description provided.

@dallinjsevy dallinjsevy requested a review from phalestrivir April 2, 2026 19:06
@phalestrivir phalestrivir force-pushed the feature/config-manager-push-cors branch from cb9aeda to 90f7dfd Compare April 6, 2026 22:31

@phalestrivir phalestrivir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one bug I found

Comment thread src/configManagerOps/FrConfigCorsOps.ts Outdated
Comment thread src/configManagerOps/FrConfigCorsOps.ts Outdated
Comment thread test/e2e/mocks/npmjs_1455397529/recording.har
Comment thread test/e2e/mocks/github_584874290/recording.har
@dallinjsevy dallinjsevy force-pushed the feature/config-manager-push-cors branch 2 times, most recently from 52a885b to 0d670b8 Compare April 9, 2026 19:00
@dallinjsevy dallinjsevy force-pushed the feature/config-manager-push-cors branch from 0d670b8 to 316e2c0 Compare May 26, 2026 21:56
@akynaston akynaston self-requested a review June 5, 2026 14:18

@akynaston akynaston left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, test passes and appears to work as intended.

@dallinjsevy dallinjsevy closed this Jun 5, 2026
@dallinjsevy dallinjsevy reopened this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants