feat: Add config-manager push raw command#78
Open
dallinjsevy wants to merge 3 commits into
Open
Conversation
dallinjsevy
force-pushed
the
feature/config-manager-push-raw
branch
2 times, most recently
from
8351261 to
4c01c61
Compare
dallinjsevy
force-pushed
the
feature/config-manager-push-raw
branch
2 times, most recently
from
a480ed2 to
1f98b35
Compare
phalestrivir
force-pushed
the
feature/config-manager-push-raw
branch
from
1f98b35 to
0b4befb
Compare
phalestrivir
requested changes
Apr 9, 2026
dallinjsevy
force-pushed
the
feature/config-manager-push-raw
branch
from
0b4befb to
4a6f2c0
Compare
dallinjsevy
force-pushed
the
feature/config-manager-push-raw
branch
from
4a6f2c0 to
8f0c6de
Compare
hfranklin
reviewed
May 29, 2026
| } else { | ||
| delete data._rev; | ||
| delete data._type; | ||
| await importRawConfig({ path: rawPath }, data); |
There was a problem hiding this comment.
Is rawPath the correct value for path? It seems importRawConfig expects path to be the URL path to the resource rather than the path to the config file.
There was a problem hiding this comment.
It looks like it's correct, this is the case when there is only one item at the path as opposed to many. However, the way this is written is pretty confusing. I left a comment suggesting some improvements to simplify this similar to how fr-config-manager does it.
phalestrivir
requested changes
Jun 12, 2026
| } else { | ||
| delete data._rev; | ||
| delete data._type; | ||
| await importRawConfig({ path: rawPath }, data); |
There was a problem hiding this comment.
It looks like it's correct, this is the case when there is only one item at the path as opposed to many. However, the way this is written is pretty confusing. I left a comment suggesting some improvements to simplify this similar to how fr-config-manager does it.
dallinjsevy
force-pushed
the
feature/config-manager-push-raw
branch
from
8f0c6de to
a17bdc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.