feat: Add config-manager push secrets#70
Conversation
dallinjsevy
force-pushed
the
feature-config-manager-push-secrets
branch
5 times, most recently
from
acb1967 to
f169ae5
Compare
phalestrivir
force-pushed
the
feature-config-manager-push-secrets
branch
from
f169ae5 to
e01e9f4
Compare
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
See my comments below for the requested changes
| ); | ||
|
|
||
| program | ||
| .description('Import ESV secrets.') |
There was a problem hiding this comment.
We are missing some flags:
-n, --name
-x, --prune
There was a problem hiding this comment.
Don't use client ESVs, delete this and instead use your own test secrets.
There was a problem hiding this comment.
Don't use client ESVs, delete this and instead use your own test secrets.
There was a problem hiding this comment.
Don't use client ESVs, delete this and instead use your own test secrets.
There was a problem hiding this comment.
Don't use client ESVs, delete this and instead use your own test secrets.
There was a problem hiding this comment.
Don't use client ESVs, delete this and instead use your own test secrets.
|
|
||
| /* | ||
| // ForgeOps | ||
| FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://nightly.gcp.forgeops.com/am frodo config-manager push secrets -D test/e2e/exports/fr-config-manager/forgeops -m cloud |
There was a problem hiding this comment.
This is not a ForgeOps test, but a cloud test, so make sure this comment reflects that. Also, we don't need to include the -m flag for cloud deployments (although it's fine to leave it in if you want to)
| const importData = JSON.parse(readFile); | ||
| const singleSecretImport: SecretsExportInterface = { | ||
| secret: { [importData._id]: importData }, | ||
| }; |
There was a problem hiding this comment.
In addition to supporting the flags I mentioned previously, we'll need to have support like we are doing for ESV variables to provide ENV that sets the variables before attempting to import them.
dallinjsevy
force-pushed
the
feature-config-manager-push-secrets
branch
from
e01e9f4 to
086d9ef
Compare
3 participants
No description provided.