Validate host in SQLAlchemy URL helper#621
Open
hashhar wants to merge 1 commit into
Open
Conversation
trino.sqlalchemy.URL() built the connection string by concatenation and never validated the host argument. Passing a value that carries a scheme, port, path, or credentials (e.g. "https://example.com") produced a malformed URL that SQLAlchemy rejected with an opaque error: ValueError: invalid literal for int() with base 10: '' Reject such a host up front with a clear ArgumentError that names the offending value and shows the expected form.
| except ValueError: | ||
| # A malformed port raises here. | ||
| has_port = True | ||
| if urlparse(host).scheme or has_port or parsed.path or parsed.username or parsed.password: |
Contributor
There was a problem hiding this comment.
urlparse(host) may raise ValueError here, are we ok with that? Maybe catch it and wrap in exc.ArgumentError?
Contributor
There was a problem hiding this comment.
Though as far as I can see, the errors are mostly raised for malformed IPv6 addresses
wendigo
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
trino.sqlalchemy.URL() built the connection string by concatenation and never validated the host argument. Passing a value that carries a scheme, port, path, or credentials (e.g. "https://example.com") produced a malformed URL that SQLAlchemy rejected with an opaque error:
Reject such a host up front with a clear ArgumentError that names the offending value and shows the expected form.
Non-technical explanation
Validate host in SQLAlchemy URL helper. Fixes #579
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: