Repository navigation
fix(core): parse run metadata returned as a JSON string #5052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
princejain756
wants to merge
2
commits into
triggerdotdev:main
Choose a base branch
from
princejain756:fix-run-metadata-string
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/core": patch | ||
| --- | ||
|
devin-ai-integration[bot] marked this conversation as resolved.
|
||
|
|
||
| `metadata.refresh()` now works against deployments where `GET /api/v1/runs/:runId/metadata` returns the run metadata as a JSON string rather than an object. The response schema parses a string payload before validating, so `refresh()` resolves with the same metadata record on every version. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { UpdateMetadataResponseBody } from "./api.js"; | ||
|
|
||
| describe("UpdateMetadataResponseBody", () => { | ||
| it("parses an object metadata payload", () => { | ||
| const result = UpdateMetadataResponseBody.safeParse({ | ||
| metadata: { key: "value", count: 2 }, | ||
| }); | ||
|
|
||
| expect(result.success).toBe(true); | ||
| if (result.success) { | ||
| expect(result.data.metadata).toEqual({ key: "value", count: 2 }); | ||
| } | ||
| }); | ||
|
|
||
| it("parses a metadata payload returned as a JSON string", () => { | ||
| const result = UpdateMetadataResponseBody.safeParse({ | ||
| metadata: '{"key":"value","count":2}', | ||
| }); | ||
|
|
||
| expect(result.success).toBe(true); | ||
| if (result.success) { | ||
| expect(result.data.metadata).toEqual({ key: "value", count: 2 }); | ||
| } | ||
| }); | ||
|
|
||
| it("rejects a metadata payload that is neither object nor valid JSON", () => { | ||
| const result = UpdateMetadataResponseBody.safeParse({ metadata: "not-json" }); | ||
|
|
||
| expect(result.success).toBe(false); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Add the opening changeset fence.
Line 1 starts with the package bump, but Changesets requires
---before the bump and after it. This file has only the closing fence. Changesets cannot read it as a valid patch changeset, which can block release commands. Add---above Line 1. (github.com)As per coding guidelines, “Changes to
packages/are customer-facing. Always add a changeset:pnpm run changeset:add.”Proposed fix
📝 Committable suggestion
Source: Coding guidelines