Fix simulation proposal estimates after workday discussion - #392
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Simulation proposal estimate publication no longer collides with the workday discussion branch. Proposal revisions use a deterministic proposal-specific local branch rooted in exact proposal provenance; no upstream publication occurs.
Work authority
golden-sdk-decision-governed-workday-intent-retry-5(draft; no decision yet)assignment_3ta4IUALf6W4_QGk1mW4EuJTiUD8mVmU, workdayworkday-0a888dd7-aaec-4203-af58-7319d9bf9d06(failed, stopped, not acceptance)dev2providerstagingatbe1e9f46613545fa7287a817435c6ca5d7b9bfbccodex/workday-simulation-proposal-head-391atfd54549353228f78a7fa81063c6a821fd1732f09Contributor mode (select one):
Plan
Trace the actual TreeDX branch/base mismatch; isolate proposal version lineage from the workday discussion branch; test the conflicting branch and sequential-estimate case; verify and retry the unchanged golden proposal from a new freeze.
Changes and commits
fd54549353228f78a7fa81063c6a821fd1732f09gives each proposal a deterministic workday-local branch rooted in its exact current provenance. This preserves strict TreeDX branch-start conflict detection and avoids adding a compatibility path.Verification
npx vitest run --config ./vitest.control-plane.config.ts tests/unit/control-plane/governance tests/unit/control-plane/capacity/planning/workday-content-source.test.ts: 13 files, 83 tests passed.npm run build: passed.npm run check:file-lengths: passed.git diff --check: passed.Risk and rollback
The proposal branch name changes for new simulation authoring only. Exact proposal source commit remains the workspace base and TreeDX rejects stale branch heads. Revert this commit before a new attempt if it fails; retry-5 was stopped, terminalized, and cannot count as acceptance. No database migration or upstream content mutation.
Completion summary
Code and focused tests ready for Actions; live golden acceptance remains pending after merge and fresh freeze. No claim that SDK/API golden passed.
AGPL committer authorization
The base-owned workflow checks the provider-authenticated pull-request author against
.github/approved-committers.json. There is no per-PR grant checkbox. If the check reports that the GitHub username is unapproved, follow the linked one-time approval form and re-run the check after the reviewed allowlist change reaches this target branch.Submission checklist