Skip to content

Gate repeated estimating on current proposal state - #389

Merged
adrianwebb merged 2 commits into
stagingfrom
codex/estimator-after-acceptance-388
Sep 20, 2026
Merged

adrianwebb merged 2 commits into
stagingfrom
codex/estimator-after-acceptance-388

Conversation

@adrianwebb

@adrianwebb adrianwebb commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Outcome

Prevent repeated planning rounds from admitting an estimator against a proposal after voting or acceptance. A racing estimator result fails closed before governance integration.

Work authority

Contributor mode (select one):

  • Human-authored
  • Agent-assisted under human authority
  • Agent-authored under human authority

Plan

Use current governance status during the single living-graph projection: estimating nodes in repeated rounds become cancelled once the proposal leaves draft/open; a racing completed result is rejected before TreeDX/governance reads and writes. Preserve completed estimator receipts and the accepted decision. Focused and live repair acceptance passed; broader SDK golden acceptance remains separate.

Changes and commits

  • febee98 gates projected estimators on current proposal state and rejects racing completions.
  • 5bd0d47 routes workday-bound Discussion lookup through the existing capacity service, with a separate-store regression test.

Verification

  • 11 focused Vitest tests pass across projector and estimate integration; 2 Discussion custody tests pass.

  • npm run build and npm run check:file-architecture pass.

  • No TypeScript diagnostics in touched files; repository-wide tsc --noEmit still fails on unrelated baseline errors.

  • trsd dev rebuild api.service completed successfully; retry-3 eight-role trsd send now posts to workday-bound Discussion. Role-specific agent responses returned; focused stale-estimator gate and all three Actions passed.

  • I ran the narrowest relevant package verification and documented any checks that could not be run.

Risk and rollback

The new projection closes only estimating nodes bound to closed proposals; historical completed assignments remain immutable. A racing result fails closed. Revert this commit through staging if regression occurs and rebuild the API in development mode. No RC, purge, or host package change.

Completion summary

This bounded repair is ready for staging integration. The complete SDK golden run, including post-acceptance scheduling, remains Platform #520 and is not claimed here.

AGPL committer authorization

The base-owned author authorization workflow governs this PR; no per-PR grant is requested.

Submission checklist

  • The change is bounded to the stated work item and target repository.
  • Exact base and head refs are recorded and the branch is ready for review.
  • Verification and compatibility evidence are recorded above.
  • No plaintext secrets, credentials, machine state, or unrelated residue are included.
  • Plan, status, commits, and completion summary form a complete durable record.
  • Rollback or recovery steps are documented and executable.

@adrianwebb
adrianwebb marked this pull request as ready for review September 20, 2026 18:09
@adrianwebb
adrianwebb merged commit be1e9f4 into staging Sep 20, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant