Integrate exact estimator results into proposal authority - #387
Merged
Merged
Conversation
adrianwebb
marked this pull request as draft
September 20, 2026 16:05
adrianwebb
marked this pull request as ready for review
September 20, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Bind modern graph estimator AssignmentResult TreeDX references to the proposal-owned execution plan before assignment completion. Merge one actor estimate or all six Reviewer review estimates into the current exact proposal without a second estimate store or legacy artifact manifest. The active SDK golden retry is underway; this PR is not yet acceptance evidence.
Work authority
Contributor mode (select one):
Plan
Use the validated general AssignmentResult and exact proposal source/workspace refs. Verify only the assigned estimate fields changed, preserve disjoint previous estimates, author one TreeDX proposal revision, bind it to governance, and only then complete the graph assignment. Reject changed authority, unrelated edits, missing estimates, and conflicts. Exercise in local development mode, then run the unchanged SDK golden campaign. No tag or RC.
Changes and commits
Verification
Focused Vitest: four tests passed.
API build: passed.
Repository file-length and architecture policy: passed.
Local trsd dev rebuild api.service: passed; API targets report ready.
Touched-file TypeScript filter: no new errors; repository-wide tsc has unrelated existing errors.
Refrozen Stage 0 manifest sha256:2efa9196764029edfe779c1ce7697ec03fc0b9ff348d465234157d20aaf64050.
Live SDK golden: running, not yet accepted.
Staging Actions: pending.
I ran the narrowest relevant package verification and documented any checks that could not be run.
I have not claimed golden acceptance from partial evidence.
No routine progress comment, release tag, RC, or package install.
Risk and rollback
Risk: TreeDX authoring succeeds but governance version binding fails, leaving an explicit unbound revision; API #385 tracks atomicity. If the live estimator projection fails or the golden graph diverges, stop the workday through trsd, preserve exact TreeDX commits as diagnostic evidence, and revert commit 3415779 on this branch. No database migration, package install, tag, or RC is included.
Completion summary
The bounded implementation and focused tests are complete. Local development rebuild is ready. The refrozen SDK golden run is active; no integrated acceptance or staging merge is claimed. Next: verify real owner and Reviewer estimates, disposition, accepted decision, and Actor/Reviewer execution before marking this PR ready.
AGPL committer authorization
The provider-authenticated PR author must be present in the base-owned approved-committers policy. No per-PR grant is requested.
Submission checklist