Skip to content

Keep SDK golden review and simulation chat within workday custody - #384

Merged
adrianwebb merged 1 commit into
stagingfrom
codex/sdk-golden-review-custody
Sep 20, 2026
Merged

adrianwebb merged 1 commit into
stagingfrom
codex/sdk-golden-review-custody

Conversation

@adrianwebb

@adrianwebb adrianwebb commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

/home/adrian/.profile: line 55: /tmp/ai-uv/env: No such file or directory
/home/adrian/.profile: line 57: /tmp/treeai-uv/env: No such file or directory
Agent pid 2013198

Outcome

Keep the SDK golden proposal-governance Reviewer within the planning window and keep simulation Discussion messages out of shared TreeDX publication/replication. Workday stop can terminalize an invalid graph through the existing writer.

Work authority

  • Work item / Issue: Closes Keep SDK golden proposal review and simulation chat within workday custody #383; Platform #520
  • Proposal / decision: golden-sdk-decision-governed-workday-intent v13; accepted decision 6bf904cf-4f00-46ef-b20e-5d7a1e996b5f
  • Assignment / checkpoint: failed diagnostic workday workday-4e7d6e11-4fa9-4823-86de-09bfc14c3a6a; not acceptance
  • Actor: Codex assistant
  • Human authority: Adrian Webb (Platform #520 delivery request)
  • Agent / capacity provider: local dev2; no generated actor acceptance claimed
  • Exact base ref: staging 3913980324c21f44b86c8aae39c7d9296964ebd9
  • Exact head ref: codex/sdk-golden-review-custody 3061d40f315faf6d5a70a6583a5d7fb7805a31be

Contributor mode (select one):

  • Human-authored
  • Agent-assisted under human authority
  • Agent-authored under human authority

Plan

Reuse one graph and one allocation path. Distinguish proposal-governance review from paired work-item review; preserve exact planning/acting budgets. Keep simulation chat on a workday ref and unpublished journal, not the project binding or replication queue. Rebuild API in local development mode, run focused tests, then retry the unchanged golden campaign. The retry is pending.

Changes and commits

  • 3061d40f — planning-phase proposal Reviewer accounting/admission, safe stop, simulation Discussion custody and regression tests.

Verification

  • npm run test:control-plane -- tests/unit/control-plane/capacity/execution/scheduling/proposal-review-phase.test.ts tests/unit/control-plane/capacity/execution/admission/allocation-inputs.test.ts tests/unit/control-plane/capacity/workday-stop-reconciliation.test.ts tests/unit/control-plane/discussions/discussion-targeted-read.test.ts tests/unit/control-plane/discussions/discussion-simulation-custody.test.ts — 19 tests in five files passed.

  • npm run build — passed.

  • trsd dev rebuild api.service --json — passed; local API readiness HTTP 200.

  • Staging Actions pending. No tag, RC, package install, purge, or bootstrap operation.

  • I ran the narrowest relevant package verification and documented any checks that could not be run.

Risk and rollback

The planning/acting boundary and Discussion replication are sensitive. Revert this one commit before any release if managed read-back fails; retain exact TreeDX commits and the failed workday receipt. No data migration is included.

Completion summary

Local repair is verified, but the SDK golden workday has not passed. The accepted proposal is immutable and the previous simulation run ended failed. A clean retry/reset needs to preserve the frozen proposal semantics and exact source refs; do not count partial evidence as completion.

AGPL committer authorization

The base-owned workflow checks the provider-authenticated pull-request author against .github/approved-committers.json. There is no per-PR grant checkbox. If the check reports that the GitHub username is unapproved, follow the linked one-time approval form and re-run the check after the reviewed allowlist change reaches this target branch.

Submission checklist

  • The change is bounded to the stated work item and target repository.
  • Exact base and head refs are recorded and the branch is ready for review.
  • Verification and compatibility evidence are recorded above.
  • No plaintext secrets, credentials, machine state, or unrelated residue are included.
  • Plan, status, commits, and completion summary form a complete durable record.
  • Rollback or recovery steps are documented and executable.

@adrianwebb
adrianwebb merged commit ff170ff into staging Sep 20, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant