Keep SDK golden review and simulation chat within workday custody - #384
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/home/adrian/.profile: line 55: /tmp/ai-uv/env: No such file or directory
/home/adrian/.profile: line 57: /tmp/treeai-uv/env: No such file or directory
Agent pid 2013198
Outcome
Keep the SDK golden proposal-governance Reviewer within the planning window and keep simulation Discussion messages out of shared TreeDX publication/replication. Workday stop can terminalize an invalid graph through the existing writer.
Work authority
golden-sdk-decision-governed-workday-intentv13; accepted decision6bf904cf-4f00-46ef-b20e-5d7a1e996b5fworkday-4e7d6e11-4fa9-4823-86de-09bfc14c3a6a; not acceptancestaging3913980324c21f44b86c8aae39c7d9296964ebd9codex/sdk-golden-review-custody3061d40f315faf6d5a70a6583a5d7fb7805a31beContributor mode (select one):
Plan
Reuse one graph and one allocation path. Distinguish proposal-governance review from paired work-item review; preserve exact planning/acting budgets. Keep simulation chat on a workday ref and unpublished journal, not the project binding or replication queue. Rebuild API in local development mode, run focused tests, then retry the unchanged golden campaign. The retry is pending.
Changes and commits
3061d40f— planning-phase proposal Reviewer accounting/admission, safe stop, simulation Discussion custody and regression tests.Verification
npm run test:control-plane -- tests/unit/control-plane/capacity/execution/scheduling/proposal-review-phase.test.ts tests/unit/control-plane/capacity/execution/admission/allocation-inputs.test.ts tests/unit/control-plane/capacity/workday-stop-reconciliation.test.ts tests/unit/control-plane/discussions/discussion-targeted-read.test.ts tests/unit/control-plane/discussions/discussion-simulation-custody.test.ts— 19 tests in five files passed.npm run build— passed.trsd dev rebuild api.service --json— passed; local API readiness HTTP 200.Staging Actions pending. No tag, RC, package install, purge, or bootstrap operation.
I ran the narrowest relevant package verification and documented any checks that could not be run.
Risk and rollback
The planning/acting boundary and Discussion replication are sensitive. Revert this one commit before any release if managed read-back fails; retain exact TreeDX commits and the failed workday receipt. No data migration is included.
Completion summary
Local repair is verified, but the SDK golden workday has not passed. The accepted proposal is immutable and the previous simulation run ended failed. A clean retry/reset needs to preserve the frozen proposal semantics and exact source refs; do not count partial evidence as completion.
AGPL committer authorization
The base-owned workflow checks the provider-authenticated pull-request author against
.github/approved-committers.json. There is no per-PR grant checkbox. If the check reports that the GitHub username is unapproved, follow the linked one-time approval form and re-run the check after the reviewed allowlist change reaches this target branch.Submission checklist