Repository navigation
Replace Yajl with the json gem for record summarization - #57
Open
Watson1978 wants to merge 1 commit into
Open
Watson1978 wants to merge 1 commit into
Watson1978 wants to merge 1 commit into
Conversation
yajl-ruby cannot be built on Ruby HEAD because it relies on internal C APIs that were removed. The json gem is a default gem, so it is always available, and it is no longer slower than yajl-ruby.
Author
|
@kenhys Can you review this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces the
yajl-rubydependency with Ruby's standardjsongem for the following reasons:yajl-rubyis no longer actively maintained and relies on internal C APIs that are removed in Ruby 4.1. Migrating to the standardjsongem ensures the plugin can continue to be built and used in future Ruby environments. Ref. [Misc #21768] Remove deprecated APIs ruby/ruby#15447, Can we release a new version for recent Ruby? brianmario/yajl-ruby#233jsongem has seen significant improvements in recent updates and now outperformsyajl-ruby.Fluentd replaced
yajl-rubyat fluent/fluentd#5383