Mirror client fixes - #1086
Merged
Merged
Conversation
roger2hk
reviewed
Jul 31, 2026
|
|
||
| // Push the checkpoint with the old size (0 if not provided). | ||
| for c.oldSize < targetSize { | ||
| // Keep trying for as long we we get conflict errors or the context is not cancelled. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Keep trying for as long we we get conflict errors or the context is not cancelled. | |
| // Keep trying for as long as we get conflict errors or the context is not cancelled. |
AlCutter
force-pushed
the
mirror_client_fixes
branch
from
August 3, 2026 16:12
93f0a0d to
49ca7fc
Compare
AlCutter
force-pushed
the
mirror_client_fixes
branch
from
August 3, 2026 16:44
49ca7fc to
054047f
Compare
roger2hk
reviewed
Aug 3, 2026
AlCutter
force-pushed
the
mirror_client_fixes
branch
2 times, most recently
from
August 4, 2026 11:32
a4d7cad to
d2c5fad
Compare
roger2hk
approved these changes
Aug 4, 2026
AlCutter
force-pushed
the
mirror_client_fixes
branch
from
August 4, 2026 14:25
d2c5fad to
5278baf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of minor fixes to the MTC mirror client:
Towards #945