cvcpkg(pycvc-cp3XX): bump cvc_revision 2→3 — republish against v2 libcvc - #449
Merged
Merged
Conversation
…bcvc The published pycvc-cp311/312/313 +cvc.2 link a PRE-v2 libcvc, so the torch<->C++ coef_mlp parity test (GRL-SNAM test_coef_mlp_parity::test_two_head_sigmoid_matches_torch) skips on 'unsupported .cvcnav format version'. Bump so publish-cvcpkg rebuilds pycvc against the v2 libcvc (.cvcnav format v2 / two-head sigmoid, #436) and the parity test runs. Recipe-only revision bump; disjoint from the wasm-guard change (#448).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps pycvc-cp311/312/313
cvc_revision2→3 so publish-cvcpkg rebuilds pycvc against the v2 libcvc (.cvcnav format v2 / two-head sigmoid, #436).Why: the published pycvc +cvc.2 links a pre-v2 libcvc, so the torch↔C++
coef_mlpv2 parity test (GRL-SNAM tests/test_coef_mlp_parity.py::test_two_head_sigmoid_matches_torch) currently SKIPS onunsupported .cvcnav format version— there's no live torch↔real-C++ parity for the v2 forward. Rebuilding pycvc on v2 makes it run.Recipe-only revision bump, disjoint from the wasm-guard change (#448). After merge I run publish-cvcpkg (with the pycvc family) so all three columns republish on v2.