Repository navigation
fix(api): keep show-shaped not_found entries in sync responses - #1097
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
A season or episode missing under a show comes back in not_found.seasons or not_found.episodes as that show, once per miss, holding only the missing season or episode. The schemas typed those buckets as plain season and episode items, so parsing dropped the show's seasons.
StefanFriptu
force-pushed
the
fix/sync-not-found-show-echo
branch
from
November 18, 2026 16:01
3b6f780 to
0319298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1063.
A season or episode missing under a show comes back in
not_found.seasons/not_found.episodesas that show: once per miss, holding only the missing season or episode. The contracts typed those buckets as plain season and episode items, so parsing a response kept onlyidsand droppedtitle,yearandseasons(the part that says what was missing).not_found.seasonsandnot_found.episodesnow also accept the show-shaped entry, the pattern ratings already used.not_founddescription now says how a miss under a show is echoed (replaces "Items echoed as sent").Type change: entries in those two buckets type
idsas optional (a show sent by title only has no ids to echo). Code reading.idsthere without a null check needs one after upgrading. No runtime change.Verified: a real
POST /sync/collectionresponse parses losslessly with the new schema; the current schema dropstitleandseasons.bun run check,bun run test(36 pass),publish:check,openapi:validateall exit 0; Biome clean on the touched files.Publish after the per-miss server response is live.