Skip to content

fix(api): keep show-shaped not_found entries in sync responses - #1097

Merged
StefanFriptu merged 1 commit into
masterfrom
fix/sync-not-found-show-echo
Nov 18, 2026
Merged

StefanFriptu merged 1 commit into
masterfrom
fix/sync-not-found-show-echo

Conversation

@StefanFriptu

Copy link
Copy Markdown
Collaborator

Part of #1063.

A season or episode missing under a show comes back in not_found.seasons / not_found.episodes as that show: once per miss, holding only the missing season or episode. The contracts typed those buckets as plain season and episode items, so parsing a response kept only ids and dropped title, year and seasons (the part that says what was missing).

  • not_found.seasons and not_found.episodes now also accept the show-shaped entry, the pattern ratings already used.
  • Covers collection add/remove, history add/remove, ratings add/remove, list items add/remove and hidden add.
  • Each not_found description now says how a miss under a show is echoed (replaces "Items echoed as sent").

Type change: entries in those two buckets type ids as optional (a show sent by title only has no ids to echo). Code reading .ids there without a null check needs one after upgrading. No runtime change.

Verified: a real POST /sync/collection response parses losslessly with the new schema; the current schema drops title and seasons. bun run check, bun run test (36 pass), publish:check, openapi:validate all exit 0; Biome clean on the touched files.

Publish after the per-miss server response is live.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T15:59:20.823904Z 3b6f780 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

A season or episode missing under a show comes back in not_found.seasons
or not_found.episodes as that show, once per miss, holding only the
missing season or episode. The schemas typed those buckets as plain
season and episode items, so parsing dropped the show's seasons.
@StefanFriptu
StefanFriptu force-pushed the fix/sync-not-found-show-echo branch from 3b6f780 to 0319298 Compare November 18, 2026 16:01
@StefanFriptu
StefanFriptu merged commit 496cfc4 into master Nov 18, 2026
9 checks passed
@StefanFriptu
StefanFriptu deleted the fix/sync-not-found-show-echo branch November 18, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant