Skip to content

feat(i18n): translations updates from CrowdIn - #715

Merged
michaldrabik merged 2 commits into
mainfrom
i18n_crowdin_updates
Nov 19, 2026
Merged

michaldrabik merged 2 commits into
mainfrom
i18n_crowdin_updates

Conversation

@trakt-bot

@trakt-bot trakt-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@trakt-bot
trakt-bot Bot requested a review from michaldrabik November 19, 2026 14:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T14:08:11.864654Z 57c8162 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57c8162e95

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

<string name="hype_tier_looking_good">Looking good</string>
<string name="image_alt_comment_gif">GIF attached to the comment</string>
<string name="image_alt_hype_score">%d%% hype for you</string>
<string name="image_alt_hype_score">%d% hype for you</string>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore escaping for literal percent signs

Changing %d%% hype to %d% hype leaves the literal percent sign unescaped, so String.format throws FormatFlagsConversionMismatchException. The same regression affects seven keys across every translated locale, and ValidateStringPlaceholdersTask checks these resources as a dependency of resources:preBuild, so builds fail during placeholder validation. Restore %% for the literal percent signs in all affected keys. .agents/rules/localization.mdL21-L22

Useful? React with 👍 / 👎.

@michaldrabik
michaldrabik merged commit 5f4e43f into main Nov 19, 2026
1 check passed
@michaldrabik
michaldrabik deleted the i18n_crowdin_updates branch November 19, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants