Skip to content

ci: gate pull requests on pnpm lint and typecheck (TRA-1249) - #223

Merged
edmacabebe merged 1 commit into
mainfrom
claude/project-thread-sm0pvf
Oct 15, 2026
Merged

edmacabebe merged 1 commit into
mainfrom
claude/project-thread-sm0pvf

Conversation

@edmacabebe

@edmacabebe edmacabebe commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Requested by edmacabebe · project thread

Before: the only workflow in this repo was sync-preview, so a PR could merge green while failing pnpm lint. That is how #216 put main red on a misformatted markdown table.

After: every pull request (and every push to main) runs a Validate / lint + typecheck job: pnpm lint (prettier and the CONTRIBUTING.md reference check) and pnpm typecheck.

pnpm build is deliberately kept out of the gate. It fetches the OpenAPI spec from the live preview API, so gating on it would make every PR depend on preview being up.

How: a new .github/workflows/validate.yml installs with the frozen lockfile on the Node version from .nvmrc and runs the two scripts. Both already pass on current main. Locally, adding an unpadded markdown table makes pnpm lint exit 1, which is the #216 failure mode.

To make a failing PR unable to merge, the lint + typecheck check still has to be marked required in the main branch protection settings. That needs repo admin.

Refs TRA-1249

🤖 Generated with Claude Code

https://claude.ai/code/session_01KxPqVqiT1VA4Dp3DzexfQy


Generated by Claude Code

The only workflow was sync-preview, so a PR failing the repo's own
validate command merged green. Run the hermetic half of it on every PR
and on main. Build stays out of the gate: it fetches the OpenAPI spec
from the live preview API.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KxPqVqiT1VA4Dp3DzexfQy
@edmacabebe edmacabebe self-assigned this Oct 9, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e4636e
Status: ✅  Deploy successful!
Preview URL: https://f59cd635.docs-4n7.pages.dev
Branch Preview URL: https://claude-project-thread-sm0pvf.docs-4n7.pages.dev

View logs

@edmacabebe
edmacabebe marked this pull request as ready for review October 9, 2026 22:58
@edmacabebe edmacabebe changed the title ci: gate pull requests on pnpm lint and typecheck ci: gate pull requests on pnpm lint and typecheck (TRA-1249) Oct 9, 2026

@mikestankavich mikestankavich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merge it

@edmacabebe
edmacabebe merged commit 6a866c5 into main Oct 15, 2026
3 checks passed
@edmacabebe
edmacabebe deleted the claude/project-thread-sm0pvf branch October 15, 2026 23:42
@edmacabebe

edmacabebe commented Oct 16, 2026 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants