Repository navigation
ci: gate pull requests on pnpm lint and typecheck (TRA-1249) - #223
Merged
Merged
Conversation
The only workflow was sync-preview, so a PR failing the repo's own validate command merged green. Run the hermetic half of it on every PR and on main. Build stays out of the gate: it fetches the OpenAPI spec from the live preview API. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KxPqVqiT1VA4Dp3DzexfQy
Deploying docs with
|
| Latest commit: |
5e4636e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f59cd635.docs-4n7.pages.dev |
| Branch Preview URL: | https://claude-project-thread-sm0pvf.docs-4n7.pages.dev |
edmacabebe
marked this pull request as ready for review
October 9, 2026 22:58
mikestankavich
left a comment
Contributor
There was a problem hiding this comment.
Looks good, merge it
Contributor
Author
|
*Status 2026-10-16: blocked on a repo admin*
- The lint + typecheck CI job merged in trakrf/docs#223
<https://linear.app/trakrf/review/ci-gate-pull-requests-on-pnpm-lint-and-typecheck-tra-1249-0c57b2d72599>.
It passes on main (6a866c5).
- It is not required yet. The ruleset main-branch-protection (id
13251914) only has pull_request and non_fast_forward, with no
required_status_checks rule. Re-checked today.
- edmacabebe is *maintain*, not admin, on trakrf/docs, so the ruleset
can't be edited from that account.
*Admin action needed:* https://github.com/trakrf/docs/rules/13251914 →
tick *Require
status checks to pass* → *Add checks* → lint + typecheck (GitHub
Actions) → *Save
changes*. Leave the other rules as they are.
If you use the API instead (PUT on the ruleset), confirm bypass_actors came
back filled in from the GET before the PUT, or the bypass list gets wiped.
*After that:* check that gh api repos/trakrf/docs/rules/branches/main lists
required_status_checks with lint + typecheck, then close this issue.
…On Mon, Oct 12, 2026 at 8:56 AM Mike Stankavich ***@***.***> wrote:
***@***.**** commented on this pull request.
Looks good, merge it
—
Reply to this email directly, view it on GitHub
<#223?email_source=notifications&email_token=ABZGZTOYILAHCUGLFRN36JD5TQT5XA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKNBYGU3TMNRWHA2KM4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5485766684>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZGZTPAVDKFXMY2WGIT2H35TQT5XAVCNFSNUABGKJSXA33TNF2G64TZHMYTCNRXGE2TIMZYGA5US43TOVSTWNJXHA2TOMBTGYZTHILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ABZGZTKDLVNICAAEXFNNIY35TQT5XA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKNBYGU3TMNRWHA2KM4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/ABZGZTLIFCJ63DL5HEDN75T5TQT5XA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKNBYGU3TMNRWHA2KM4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you were assigned.Message ID:
***@***.***>
--
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by edmacabebe · project thread
Before: the only workflow in this repo was
sync-preview, so a PR could merge green while failingpnpm lint. That is how #216 putmainred on a misformatted markdown table.After: every pull request (and every push to
main) runs a Validate / lint + typecheck job:pnpm lint(prettier and the CONTRIBUTING.md reference check) andpnpm typecheck.pnpm buildis deliberately kept out of the gate. It fetches the OpenAPI spec from the live preview API, so gating on it would make every PR depend on preview being up.How: a new
.github/workflows/validate.ymlinstalls with the frozen lockfile on the Node version from.nvmrcand runs the two scripts. Both already pass on currentmain. Locally, adding an unpadded markdown table makespnpm lintexit 1, which is the #216 failure mode.To make a failing PR unable to merge, the
lint + typecheckcheck still has to be marked required in themainbranch protection settings. That needs repo admin.Refs TRA-1249
🤖 Generated with Claude Code
https://claude.ai/code/session_01KxPqVqiT1VA4Dp3DzexfQy
Generated by Claude Code