Conversation
…5069) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com> Co-authored-by: Hanric <hanric.zhang@gmail.com>
…odule-federation#5113) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ule-federation#5017) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ScriptedAlchemy <zackary.l.jackson@gmail.com>
…ule-federation#5020) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ScriptedAlchemy <zackary.l.jackson@gmail.com>
…ter-demo/router-remote4-2004 (module-federation#5041) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ScriptedAlchemy <zackary.l.jackson@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zack Jackson <25274700+ScriptedAlchemy@users.noreply.github.com> Co-authored-by: ScriptedAlchemy <zackary.l.jackson@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hanric <hanric.zhang@gmail.com> Co-authored-by: ScriptedAlchemy <zackary.l.jackson@gmail.com>
…5056) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zack Jackson <25274700+ScriptedAlchemy@users.noreply.github.com> Co-authored-by: ScriptedAlchemy <zackary.l.jackson@gmail.com>
…odule-federation#5114) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Moves the repo's @rspack/core, @rspack/cli and @rspack/dev-server to 2.x (core and cli 2.1.10, dev-server 2.2.1). The @module-federation/rspack peer range already accepts ^2.0.0-0. Demo apps drop experiments.css for a css/auto rule and turn off lazy compilation for remotes served by rspack serve.
…() (module-federation#5148) esbuild reports metafile output paths relative to absWorkingDir. The plugin resolved them, and the manifest's shared package.json lookups, from process.cwd(), so a build with a different absWorkingDir failed with ENOENT on dist/remoteEntry.js or wrote its manifest next to the process. Builds that do not set absWorkingDir are unchanged.
module-federation#5116) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tion#5115) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Do not serve another app's tree-shaken shared chunk when its exports do not cover the consumer. Prefer providedExports over usedExports, skip unsafe same-version overwrites of disjoint variants, and stamp compiled usedExports onto provider treeShaking.providedExports at init.
Bundle Size Report25 package(s) changed, 18 unchanged. Package dist + ESM entry
Bundle targets
Tree-shakable entrypoints
Consumer scenarios
Total dist (raw): 23.43 MB (-13354058 B (-35.2%)) Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
shared[x].treeShaking.mode: 'runtime-infer'could serve another app's tree-shaken chunk when two non-singleton providers registered the same version with different exports. The consumer then threw on a missing export and never loaded the independent full fallback.This change only uses a tree-shaken variant when the provider's offered exports (
providedExports, elseusedExports) cover the consumer. Otherwise it uses the full getter. Same-version registration also skips overwriting disjoint tree-shaken variants by app-name order. Webpack/Rspack init now stamps compiledusedExportsonto providertreeShaking.providedExportswhen that list is present.How to verify
The new
runtime-infer-share-coveragetests cover two same-version providers with disjoint exports in both app-name orders.Related Issue
No tracked issue. Bug report: non-singleton
runtime-infersame-version shares with disjoint exports loaded the wrong tree-shaken chunk.Types of changes
Checklist