fix: preserve total width when snapping#888
Open
phryneas wants to merge 1 commit into
Open
Conversation
When the dragged divider snapped, the leading pane was moved to the left or right without an opposite adjustment to the trailing pane — so the total width would change and the layout drifted. Snap the leading pane and subtract the same delta from the trailing pane, so the two together preserve the total.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug that I encountered when I worked with snapping:
When the dragged divider snapped, the leading pane was moved to the left or right without an opposite adjustment to the trailing pane — so the total width would change and the layout drifted.
This one should fix it.
Disclosure - I've used Claude for this one, but double-triple-checked everything by hand five times. This is not a drive-by slop PR.