Moqui integration-testing reference — auth + wiring, folded into verification & QA#18
Open
patelanil wants to merge 1 commit into
Open
Moqui integration-testing reference — auth + wiring, folded into verification & QA#18patelanil wants to merge 1 commit into
patelanil wants to merge 1 commit into
Conversation
…rification & QA Two silent failure modes learned building an oms-test replay suite: 1. Wiring — a component with no build.gradle is invisible to Gradle, and a spec absent from the suite's @SelectClasses never runs; either way 'gradle test' is green having run nothing. Green != ran. 2. Auth — the active realm (co.hotwax.auth.OfbizShiroRealm) authenticates against OFBiz UserLogin, not UserAccount username, so a UserLogin row must exist; 'No account found' is misleading. Use the demo admin hotwax.user with internalLoginUser (force-login, no password), and load its demo data file in setupSpec so the suite is self-contained on a fresh/CI DB. Plus disableAuthz for raw entity access and clearErrors to stop error-cascade across features. New asset assets/moqui-integration-testing.md; cited from moqui-verification (step 5 + references) and moqui-qa-technician (the ultimate hollow green). Plugin 0.9.0 -> 0.9.1; README asset count corrected to 19.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Harvested from building an
oms-testsuite that replays a real Shopify order through the productionsync#ShopifyOrderand asserts existing validators. Two silent failure modes cost real time and belong in the shared knowledge, not one project's memory.What's folded (learnings 1 & 2)
1. Wiring — green ≠ ran.
runtime/component/<name>with nobuild.gradleis invisible to Gradle (settings.gradlegetDirectoryProjects()requires one).gradle testskips it — green, zero specs run.@SelectClassesnever runs either. The suite class is the registry.2. Auth in an integration test.
co.hotwax.auth.OfbizShiroRealmauthenticates against OFBizUserLogin, notmoqui.security.UserAccountusername — aUserAccountwithout a matchingUserLoginfails with a misleading "No account found".hotwax.user(oms/data/JA_Demo_AJ_HCUserData.xml) withinternalLoginUser(force-login, no password, no credential in the repo). Don't fabricate a per-test user.setupSpecso the suite is self-contained on a fresh/CI DB.disableAuthz(paired) for raw entity access, andec.message.clearErrors()per feature so a stuck error doesn't cascade into unrelated assertions.Changes
assets/moqui-integration-testing.md.skills/moqui-verification/SKILL.md(step 5 + References) andskills/moqui-qa-technician/SKILL.md(the ultimate hollow green is a suite that ran nothing).0.9.0→0.9.1; README asset count corrected (was stale at 15) → 19.Coach notes
sync#ShopifyOrderinput-shape contract) were not folded here — they land in the order-engine docs + the connector PR, per the routing table.