Skip to content

refactor: type cached certificate phases - #40

Merged
0xcadams merged 1 commit into
0xcadams/type-benchmark-choicesfrom
0xcadams/type-client-certificate-phase
Oct 1, 2026
Merged

0xcadams merged 1 commit into
0xcadams/type-benchmark-choicesfrom
0xcadams/type-client-certificate-phase

Conversation

@0xcadams

@0xcadams 0xcadams commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

What

Use a private, finite phase type for certificates cached in client SQLite state.

Why

The client schema restricts saved certificate material to pending or current, but cache helpers accepted a generic phase string. Keeping the choice typed inside the cache makes staging and promotion boundaries explicit.

Changes

  • Carry pending/current phase values through certificate-cache helpers.
  • Convert phases to SQLC strings only at SQLite query parameters, preserving stored values and certificate behavior.

@0xcadams
0xcadams force-pushed the 0xcadams/type-client-certificate-phase branch from 7f544a8 to c57d049 Compare October 1, 2026 06:02
@0xcadams
0xcadams changed the base branch from main to 0xcadams/type-benchmark-choices October 1, 2026 06:03
@0xcadams
0xcadams added this pull request to stack #43 October 1, 2026 06:03
@0xcadams
0xcadams force-pushed the 0xcadams/type-client-certificate-phase branch from c57d049 to 3a3c8e7 Compare October 1, 2026 06:30
@0xcadams
0xcadams merged commit 88cb115 into main Oct 1, 2026
25 of 27 checks passed
@0xcadams
0xcadams deleted the 0xcadams/type-client-certificate-phase branch October 1, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant