Skip to content

refactor: type benchmark workload choices - #39

Merged
0xcadams merged 1 commit into
0xcadams/type-client-choicesfrom
0xcadams/type-benchmark-choices
Oct 1, 2026
Merged

0xcadams merged 1 commit into
0xcadams/type-client-choicesfrom
0xcadams/type-benchmark-choices

Conversation

@0xcadams

@0xcadams 0xcadams commented Oct 1, 2026

Copy link
Copy Markdown
Member

What

Carry benchmark suite, publisher transport choice, visitor network, and plan output format as finite types through planning and execution.

Why

The benchmark CLI already restricts these inputs, but its handwritten plan and publisher workload passed generic strings across functions. That also blurred the distinction between selecting a benchmark transport cohort and reporting an actual QUIC or TLS/TCP transport.

Changes

  • Define benchmark-specific choices and a shared publisher transport choice, retaining existing enum flags and runtime checks.
  • Preserve plan JSON and benchmark approval requirements while converting only at the visitor socket and reported transport boundaries.
  • Pass a typed cohort choice from the separated runtime workload harness.

@0xcadams
0xcadams force-pushed the 0xcadams/type-benchmark-choices branch from e8c9d08 to dd000e0 Compare October 1, 2026 06:02
@0xcadams
0xcadams changed the base branch from main to 0xcadams/type-client-choices October 1, 2026 06:03
@0xcadams
0xcadams added this pull request to stack #43 October 1, 2026 06:03
@0xcadams
0xcadams force-pushed the 0xcadams/type-benchmark-choices branch from dd000e0 to 2c49ed3 Compare October 1, 2026 06:30
@0xcadams
0xcadams merged commit 54d686d into main Oct 1, 2026
23 checks passed
@0xcadams
0xcadams deleted the 0xcadams/type-benchmark-choices branch October 1, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant