refactor: type finite client CLI choices - #38
Merged
0xcadams merged 1 commit intoOct 1, 2026
Merged
Conversation
0xcadams
force-pushed
the
0xcadams/type-client-choices
branch
from
October 1, 2026 06:02
a3b4e0b to
b50f008
Compare
0xcadams
added this pull request to stack #43
October 1, 2026 06:03
0xcadams
force-pushed
the
0xcadams/type-client-choices
branch
from
October 1, 2026 06:30
b50f008 to
9ed2ded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep finite tnl role, maintenance-control, output-mode, and NDJSON event choices typed within the client CLI.
Why
Kong already restricts CLI choices, and generated APIs define the role and maintenance values, but command handlers passed them around as generic strings. NDJSON event kinds also have a fixed emitted set.
Changes