Skip to content

fix(release): guard bundle jobs against transitive skip #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senamakel merged 1 commit into from
Aug 11, 2026
Merged

fix(release): guard bundle jobs against transitive skip #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,11 @@ jobs:
native-bundles:
name: Module bundle (${{ matrix.id }})
needs: release-target
# `always()` is required even though `release-target` succeeds: GitHub
# propagates a skip transitively, so a skipped `publish` upstream would
# skip this job regardless of its direct dependency's result. The explicit
# success check is what actually gates it.
if: ${{ always() && needs.release-target.result == 'success' }}
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -346,6 +351,11 @@ jobs:
needs:
- release-target
- native-bundles
# Same transitive-skip rule as above.
if: >-
${{ always()
&& needs.release-target.result == 'success'
&& needs.native-bundles.result == 'success' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
Expand Down