feat(module): expose query-less document recall - #12
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Warning Review limit reached
Next review available in: 112 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds query-less namespace document recall to ChangesDocument recall
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: 🔵 Low · up to The PR adds query-less document recall to the shared API and exposes it through TinyBus. It is mergeable with owner awareness: the public trait change needs a compatibility/release decision, and caller-controlled limits should be confirmed safe for any untrusted access. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api/src/provider/content.rs`:
- Around line 147-150: Update the recall_documents documentation’s # Errors
section to include MemoryError::Unsupported when the Documents capability is
unavailable, or explicitly scope backend-failure handling to after capability
negotiation. Keep the existing empty-namespace behavior documented.
- Around line 140-154: Update the MemoryDocuments::recall_documents trait method
to provide a default implementation so existing external implementors remain
source-compatible, unless the release is explicitly treated as a pre-1.0 minor
breaking release. Extend its # Errors documentation to include
MemoryError::Unsupported, matching NullMemoryProvider’s behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 24939186-4fff-43b7-a0e5-2a2654619d36
📒 Files selected for processing (4)
api/src/null.rsapi/src/provider/content.rscrates/tinymemory-module/src/provider.rscrates/tinymemory-module/src/service/mod.rs
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Summary
MemoryDocumentscontract with query-less recallWhy
An empty ranked query does not preserve the semantics or rendered context of query-less namespace recall. OpenHuman needs this method to finish moving its document RPC boundary onto the compiled TinyMemory module.
Verification
cargo check --all-features --manifest-path Cargo.tomlcargo check --all-features --manifest-path crates/tinymemory-module/Cargo.tomlcargo fmt --all -- --checkSummary by CodeRabbit