Skip to content

os: add File.Chown on the unix path #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0pcom wants to merge 1 commit into
base: dev
Choose a base branch
from
+13 −0
Open

os: add File.Chown on the unix path #5589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/os/file_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,19 @@ func (f *File) Truncate(size int64) (err error) {
return Truncate(f.name, size)
}

// Chown changes the numeric uid and gid of the named file. It mirrors Truncate:
// the unix os.File was missing this method (it exists only on the baremetal/wasm

@b0ch3nski b0ch3nski Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the history of the change is not necessary to stay as a code comment when its not relevant to the implementation

@dgryski dgryski Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Please change the comment to simply document os.Chown.

// path in file_other.go), which broke callers such as github.com/pkg/sftp that
// require the full os.File surface. Delegates to the package-level Chown
// (file_anyos.go) on the file's path.
func (f *File) Chown(uid, gid int) error {
if f.handle == nil {
return ErrClosed
}

return Chown(f.name, uid, gid)
}

func (f *File) chmod(mode FileMode) error {
if f.handle == nil {
return ErrClosed
Expand Down