Repository navigation
TrailView: the modelling kit, the style guide and the animals remade (#3786) #3801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timohueser
wants to merge
7
commits into
develop
Choose a base branch
from
claude/trailview-3786-animals
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,111
−127
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a19148a
trailview: the modelling kit, animal breed files with poses and two t…
timohueser 354d071
trailview: the animals in the soft low-poly style, 14 breeds in 3 pos…
timohueser 3c3c4a5
trailview: herds of ibex, chamois, deer, reindeer, pig, donkey, drome…
timohueser cc47d5d
trailview: a region's herds take their models when the region comes i…
timohueser 2a9fb19
docs: the TrailView model style guide
timohueser f144c1e
trailview: review fixes: only drawn herds take models, chain caps fac…
timohueser 0fec26e
docs: the image paths of the TrailView model guide
timohueser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skip regional herd placement when showroom animals are present.
When the showroom has at least one resolved breed entry,
update()still places every regional herd in reach. Each placement reserves instance models and queues breed file loads. The shader returns fromherds_ofbefore it draws regional herds, so these loads and reservations serve no visible purpose. The queued files also delayidleuntil they settle, and the reserved models use instance slots.Run regional placement only when
showCount === 0. The showroom count does not change after construction, so this skips placement in showroom mode and leaves regular rendering unchanged. Rock models load in the constructor and are not affected.Suggested fix
Committable suggestion