Repository navigation
web: delete the old map builder page (step 2 of #3496) - #3525
Merged
Merged
Conversation
The web app at /plan/ is the only page. The entry of /builder/, the parts that only it used, the style and schema editor, its Python server and the task `obc web` go. The web host is the one host in every mode, so `npm run dev`, `npm run build`, `npm run check` and vitest use it. `MapRun.download()` and `sendMapFile` go: no page saves a map as a file. The three base map cases move to the area page. The suites web.builder-browser, live.builder-memory and python.builder, and the CI job builder-python, go. The deploy no longer builds /builder/, and the Maps links point at the Device page. Co-Authored-By: Claude Opus <noreply@anthropic.com>
Co-Authored-By: Claude Opus <noreply@anthropic.com>
The pretend device gives back its map and can hold a put, so the area journey compares the sent map with the pinned map byte for byte, and stops a send while the put runs. A unit test holds that Stop does not abort a send once the device has each byte. The packer cases of the routing-profile test move to obc-bake with their own suite and CI job. MapRun loses the members only the old page read, and the host alias goes. The link check no longer skips links to builder/, and the launch entries of the deleted server go. Co-Authored-By: Claude Opus <noreply@anthropic.com>
Contributor
|
Important Review skippedToo many files! This PR contains 138 files, which is 38 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
…-builder-page # Conflicts: # docs/design/README.md
Co-Authored-By: Claude Opus <noreply@anthropic.com>
The local frontend gate no longer calls the deleted build:all; its vitest step builds the app. The option to keep downloaded map data goes, so each run clears the work files of the runs before it. The route upload of the old page, two unused format helpers, saveBytes and the static and log options of the fixture server go. The 503 base map case checks again that only the tile host is asked, and false sentences that named the map builder are correct. Co-Authored-By: Claude Opus <noreply@anthropic.com>
No run reuses the cells of another, so openCellInventory, the stored-cell term of the disk projection and their tests go. Co-Authored-By: Claude Opus <noreply@anthropic.com>
timohueser
marked this pull request as ready for review
November 15, 2026 21:43
timohueser
enabled auto-merge
November 15, 2026 21:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mode: change #3496
Part of #3496 (step 2 of 3)
Requirements: SYS-001, SYS-003, SYS-007, SYS-010, SYS-011, SYS-012, SYS-015, SYS-017, SYS-018, SYS-020, SYS-021, SYS-023, SYS-024
Public docs changed: one link of
docs/content/index.md("Prepare a map" goes to/plan/#/device), in its owndocs:commit. The landing page and the docs header point "Maps" at/plan/#/devicetoo.What changed
/builder/is gone: its entry (index.html,main.ts,App.svelte,routes/,styles/app.css), the parts that only it used, and their tests.components/advanced/**,lib/config/**,lib/schema/**,lib/palette.ts,lib/api/client.ts,lib/platform/dev.ts,builder/server/**, the server tests ofbuilder/tests/, the taskobc web, the Python groupsbuilderandbuilder-test.$hostis gone:lib/platform/index.tsimports./web.npm run buildbuilds the web app (build:planner).npm run dev,npm run checkand vitest use the web host.bundle.test.tsinspects the build of the web app, withNODE_ENV=production(vitest setstest, and that build ships the pretend device).MapRun.download(),sendMapFileand the members ofMapRunthat only the old page read are gone. The kept tests offlows.test.tssend a built map (sendMapBlob) and keep their names.obcm.keepMapCells) is gone: no run reuses the cells of another, andstart()of each run clears the map work files. So cells that a rider kept on the old page go at the next "Send the map".lib/device/route.tswith its test,sendRouteand the "route upload" cases offlows.test.ts(no requirement cites them; the sync sends routes withrouteObcroflib/device-sync/route.ts),formatRate,formatDuration,saveBytes, and--staticand--logoftools/fixture_catalog.py.flows.test.tsno longer loads the conversion bridge, so the cycledevice-link -> map-assemblyleaves the cairn baseline.obc check frontendno longer runsnpm run build:all:bundle.test.tsin its vitest step builds the web app.basemap.test.jsare intests/browser/planner/area.test.js.area.test.jscompares the map on the pretend device withbuilder/wasm/tests/fixture/expected/map.obcm, byte for byte. The pretend device gives back its map (deviceTest.map()).area.test.jsstops the send while the put runs (deviceTest.holdPut()): the card keeps its map, and the new map waits.state.svelte.test.ts"does not stop a map send once the device has each byte": Stop in the phasescommittingandfinalizingdoes not abort the send.host/obc-bake/tests/test_routing_profiles.py, in the suitepython.packer-profilesand the CI jobpacker-python(the oldbuilder-pythonjob without the server tests).web.builder-browser,live.builder-memoryandpython.buildergo.web.planner-requestscarries the journeys of the web app, so it triggers onbuilder/web/src/**,builder/wasm/**andtools/fixture_catalog.py. The step "production builds" of thewebjob goes. The deploy builds only the web app and checks/plan/for a baked-in site path.obc siteserves the web app at/planner.html.docs/build_docs.pyno longer skips links tobuilder/..claude/launch.jsonlosesweb-builderandweb-builder-static.Rule change
The guard
tools/check_data_sources.pygoverns fewer paths:builder/server/**leaves itsGOVERNS,RULEand scan scope, because the folder is gone.Byte comparison of
assemble-download.test.js"Send the map" in
area.test.jsnow holds the bytes of a map built in Chromium (catalog download, worker, OPFS) to the pinned map.bridge.test.ts"assembleCells > reproduces the native CLI's bytes" keeps the same comparison in Node.Differences from the plan
builder/tests/corpus/**stays: the Rust tests ofobc-bakeand the packer profile test read its.pbffiles.lib/config/model.tswith its test (only the editor used it),test-support/coverage/Selection.svelte,public/osm_catalog.json,builder/palette.json,builder/__init__.py,lib/platform/hosts.test.ts, the fieldnameofPlatform, and the scriptsbuild:web,build:allandpreview.hostFor()is a mode check now (checkMode).tools/tests/test_data_registry.pyno longer reads the footer ofApp.svelte. The test of the selection plan for the config schema goes: only Rust reads the schema now.docs/design/web-planner.mdand the false parts ofdocs/design/device-map-builder.mdchanged;.cairn/baseline.jsondrops three cycle entries that are gone.Notes
developremovedlib/catalog/lasso.tsand the corridor in commit d3f7b83. The wasm bridge has no export of its own for them. SYS-001 criteria 3 and 4 and SYS-003 cite tests that are already gone.live.builder-memory).SchemaPreview(SchemaMapPreviewinbuilder/wasm/src/preview.rs,preview_web.rs) has no caller now, and it ships in the core wasm of each visitor. Its removal needs a Rust build, so it is not in this pull request.Checks
obc check frontend: passed in 185 s (wasm bridges, svelte-check, vitest 1662 passed).npm run test:planner -- area.test.js device.test.js: 15 passed, with the byte comparison and the Stop during the put. The whole planner suite passed 38 of 39 before this round; a case ofhome.test.jsfailed once and passed on a rerun.npm run build, andnpm run devwith the web host.obc suites check: OK (56 suites, 22 CI jobs).obc cairn check: 53 violations, baseline 53, 0 new.python3 tools/check_data_sources.py: OK.host/obc-bake/tests/test_routing_profiles.py: collects; its 4 cases skip here, because noobc-packbinary is built (CI builds it).python3 docs/build_docs.py --check-links: OK, with no skip forbuilder/.🤖 Generated with Claude Code