Skip to content

web: delete the old map builder page (step 2 of #3496) - #3525

Merged
timohueser merged 7 commits into
developfrom
claude/3496-delete-builder-page
Nov 15, 2026
Merged

timohueser merged 7 commits into
developfrom
claude/3496-delete-builder-page

Conversation

@timohueser

@timohueser timohueser commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Mode: change #3496
Part of #3496 (step 2 of 3)
Requirements: SYS-001, SYS-003, SYS-007, SYS-010, SYS-011, SYS-012, SYS-015, SYS-017, SYS-018, SYS-020, SYS-021, SYS-023, SYS-024

Public docs changed: one link of docs/content/index.md ("Prepare a map" goes to /plan/#/device), in its own docs: commit. The landing page and the docs header point "Maps" at /plan/#/device too.

What changed

  • The old map builder page at /builder/ is gone: its entry (index.html, main.ts, App.svelte, routes/, styles/app.css), the parts that only it used, and their tests.
  • The developer editor for styles and schemas is gone: components/advanced/**, lib/config/**, lib/schema/**, lib/palette.ts, lib/api/client.ts, lib/platform/dev.ts, builder/server/**, the server tests of builder/tests/, the task obc web, the Python groups builder and builder-test.
  • One host. The alias $host is gone: lib/platform/index.ts imports ./web. npm run build builds the web app (build:planner). npm run dev, npm run check and vitest use the web host. bundle.test.ts inspects the build of the web app, with NODE_ENV=production (vitest sets test, and that build ships the pretend device).
  • MapRun.download(), sendMapFile and the members of MapRun that only the old page read are gone. The kept tests of flows.test.ts send a built map (sendMapBlob) and keep their names.
  • The option "Keep downloaded map data" (obcm.keepMapCells) is gone: no run reuses the cells of another, and start() of each run clears the map work files. So cells that a rider kept on the old page go at the next "Send the map".
  • More code that only the old page used is gone: lib/device/route.ts with its test, sendRoute and the "route upload" cases of flows.test.ts (no requirement cites them; the sync sends routes with routeObcr of lib/device-sync/route.ts), formatRate, formatDuration, saveBytes, and --static and --log of tools/fixture_catalog.py. flows.test.ts no longer loads the conversion bridge, so the cycle device-link -> map-assembly leaves the cairn baseline.
  • obc check frontend no longer runs npm run build:all: bundle.test.ts in its vitest step builds the web app.
  • Device page: "Disconnect" stays, the sentence about the map builder goes, and the error says "Another tab uses the device". The footer link "Map builder" goes.
  • Tests:
    • The three base map cases of basemap.test.js are in tests/browser/planner/area.test.js.
    • "Send the map" in area.test.js compares the map on the pretend device with builder/wasm/tests/fixture/expected/map.obcm, byte for byte. The pretend device gives back its map (deviceTest.map()).
    • A new case in area.test.js stops the send while the put runs (deviceTest.holdPut()): the card keeps its map, and the new map waits.
    • state.svelte.test.ts "does not stop a map send once the device has each byte": Stop in the phases committing and finalizing does not abort the send.
    • The packer cases of the routing-profile test move to host/obc-bake/tests/test_routing_profiles.py, in the suite python.packer-profiles and the CI job packer-python (the old builder-python job without the server tests).
  • CI and tooling: the suites web.builder-browser, live.builder-memory and python.builder go. web.planner-requests carries the journeys of the web app, so it triggers on builder/web/src/**, builder/wasm/** and tools/fixture_catalog.py. The step "production builds" of the web job goes. The deploy builds only the web app and checks /plan/ for a baked-in site path. obc site serves the web app at /planner.html. docs/build_docs.py no longer skips links to builder/. .claude/launch.json loses web-builder and web-builder-static.

Rule change

The guard tools/check_data_sources.py governs fewer paths: builder/server/** leaves its GOVERNS, RULE and scan scope, because the folder is gone.

Byte comparison of assemble-download.test.js

"Send the map" in area.test.js now holds the bytes of a map built in Chromium (catalog download, worker, OPFS) to the pinned map. bridge.test.ts "assembleCells > reproduces the native CLI's bytes" keeps the same comparison in Node.

Differences from the plan

  • builder/tests/corpus/** stays: the Rust tests of obc-bake and the packer profile test read its .pbf files.
  • More files go than the plan names: lib/config/model.ts with its test (only the editor used it), test-support/coverage/Selection.svelte, public/osm_catalog.json, builder/palette.json, builder/__init__.py, lib/platform/hosts.test.ts, the field name of Platform, and the scripts build:web, build:all and preview.
  • hostFor() is a mode check now (checkMode).
  • tools/tests/test_data_registry.py no longer reads the footer of App.svelte. The test of the selection plan for the config schema goes: only Rust reads the schema now.
  • Two sentences of docs/design/web-planner.md and the false parts of docs/design/device-map-builder.md changed; .cairn/baseline.json drops three cycle entries that are gone.

Notes

  • The lasso and the corridor (the owner removed them for good) have no code left on this branch: develop removed lib/catalog/lasso.ts and the corridor in commit d3f7b83. The wasm bridge has no export of its own for them. SYS-001 criteria 3 and 4 and SYS-003 cite tests that are already gone.
  • No test is left for the estimator against a real country-scale assembly (live.builder-memory).
  • A rest for a later change: the wasm export SchemaPreview (SchemaMapPreview in builder/wasm/src/preview.rs, preview_web.rs) has no caller now, and it ships in the core wasm of each visitor. Its removal needs a Rust build, so it is not in this pull request.

Checks

  • obc check frontend: passed in 185 s (wasm bridges, svelte-check, vitest 1662 passed).
  • npm run test:planner -- area.test.js device.test.js: 15 passed, with the byte comparison and the Stop during the put. The whole planner suite passed 38 of 39 before this round; a case of home.test.js failed once and passed on a rerun.
  • npm run build, and npm run dev with the web host.
  • obc suites check: OK (56 suites, 22 CI jobs). obc cairn check: 53 violations, baseline 53, 0 new.
  • Python tests of the changed tools: 70 passed. python3 tools/check_data_sources.py: OK.
  • host/obc-bake/tests/test_routing_profiles.py: collects; its 4 cases skip here, because no obc-pack binary is built (CI builds it).
  • python3 docs/build_docs.py --check-links: OK, with no skip for builder/.
  • Left out: the data and TrailView browser suites, Rust tests.

🤖 Generated with Claude Code

timohueser and others added 3 commits November 15, 2026 22:02
The web app at /plan/ is the only page. The entry of /builder/, the parts
that only it used, the style and schema editor, its Python server and the
task `obc web` go. The web host is the one host in every mode, so
`npm run dev`, `npm run build`, `npm run check` and vitest use it.
`MapRun.download()` and `sendMapFile` go: no page saves a map as a file.

The three base map cases move to the area page. The suites
web.builder-browser, live.builder-memory and python.builder, and the CI
job builder-python, go. The deploy no longer builds /builder/, and the
Maps links point at the Device page.

Co-Authored-By: Claude Opus <noreply@anthropic.com>
Co-Authored-By: Claude Opus <noreply@anthropic.com>
The pretend device gives back its map and can hold a put, so the area
journey compares the sent map with the pinned map byte for byte, and
stops a send while the put runs. A unit test holds that Stop does not
abort a send once the device has each byte. The packer cases of the
routing-profile test move to obc-bake with their own suite and CI job.
MapRun loses the members only the old page read, and the host alias
goes. The link check no longer skips links to builder/, and the launch
entries of the deleted server go.

Co-Authored-By: Claude Opus <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 138 files, which is 38 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 01d08607-5391-4a42-8591-9b6ba003cd3d
Commits

Reviewing files that changed from the base of the PR and between 2a9eecc and a27555b.

Files ignored due to path filters: 1

  • uv.lock is excluded by !**/*.lock
Files selected for processing: 138

  • .cairn/baseline.json
  • .claude/launch.json
  • .github/workflows/ci.yml
  • .github/workflows/deploy-site.yml
  • .gitignore
  • README.md
  • builder/__init__.py
  • builder/palette.json
  • builder/server/__init__.py
  • builder/server/__main__.py
  • builder/server/paths.py
  • builder/server/schema_preview.py
  • builder/server/server.py
  • builder/tests/test_schema_preview.py
  • builder/tests/test_schema_source.py
  • builder/web/index.html
  • builder/web/package.json
  • builder/web/public/osm_catalog.json
  • builder/web/src/App.svelte
  • builder/web/src/Shell.svelte
  • builder/web/src/components/ConfirmDialog.svelte
  • builder/web/src/components/Header.svelte
  • builder/web/src/components/UpdatePrompt.svelte
  • builder/web/src/components/advanced/CategoryRail.svelte
  • builder/web/src/components/advanced/ClimbWeightCell.svelte
  • builder/web/src/components/advanced/ColorControl.svelte
  • builder/web/src/components/advanced/LodSegments.svelte
  • builder/web/src/components/advanced/LodTiers.svelte
  • builder/web/src/components/advanced/MultiplierCell.svelte
  • builder/web/src/components/advanced/OptionalColorControl.svelte
  • builder/web/src/components/advanced/OutputTab.svelte
  • builder/web/src/components/advanced/ProfilesTab.svelte
  • builder/web/src/components/advanced/ProfilesTab.svelte.test.ts
  • builder/web/src/components/advanced/SchemaField.svelte
  • builder/web/src/components/advanced/SchemaLab.svelte
  • builder/web/src/components/advanced/StyleTable.svelte
  • builder/web/src/components/coverage/CoverageHome.svelte
  • builder/web/src/components/coverage/CoverageHome.svelte.test.ts
  • builder/web/src/components/coverage/DownloadStep.svelte
  • builder/web/src/components/coverage/DownloadStep.svelte.test.ts
  • builder/web/src/components/coverage/MapSummary.svelte
  • builder/web/src/components/coverage/MapSummary.svelte.test.ts
  • builder/web/src/components/coverage/PartsList.svelte
  • builder/web/src/components/device/CardFormat.svelte
  • builder/web/src/components/device/DeviceStep.svelte
  • builder/web/src/components/device/DeviceSurfaces.svelte
  • builder/web/src/components/device/FirmwareCard.svelte
  • builder/web/src/components/device/MapSend.svelte
  • builder/web/src/components/device/MapSend.svelte.test.ts
  • builder/web/src/components/device/RideExport.svelte
  • builder/web/src/components/device/RouteDrop.svelte
  • builder/web/src/components/device/TransferBar.svelte
  • builder/web/src/components/device/TransferBar.svelte.test.ts
  • builder/web/src/lib/api/client.ts
  • builder/web/src/lib/cells/quota.test.ts
  • builder/web/src/lib/cells/quota.ts
  • builder/web/src/lib/cells/store.test.ts
  • builder/web/src/lib/cells/store.ts
  • builder/web/src/lib/config/edit.test.ts
  • builder/web/src/lib/config/edit.ts
  • builder/web/src/lib/config/model.test.ts
  • builder/web/src/lib/config/model.ts
  • builder/web/src/lib/config/profiles.test.ts
  • builder/web/src/lib/config/profiles.ts
  • builder/web/src/lib/config/schema_fields.test.ts
  • builder/web/src/lib/config/schema_fields.ts
  • builder/web/src/lib/config/storage.svelte.ts
  • builder/web/src/lib/constants.ts
  • builder/web/src/lib/coverage/run.svelte.ts
  • builder/web/src/lib/device-sync/map.svelte.test.ts
  • builder/web/src/lib/device-sync/map.svelte.ts
  • builder/web/src/lib/device-sync/state.svelte.test.ts
  • builder/web/src/lib/device/flows.test.ts
  • builder/web/src/lib/device/job.svelte.test.ts
  • builder/web/src/lib/device/job.svelte.ts
  • builder/web/src/lib/device/progress.ts
  • builder/web/src/lib/device/rides.test.ts
  • builder/web/src/lib/device/rides.ts
  • builder/web/src/lib/device/route.test.ts
  • builder/web/src/lib/device/route.ts
  • builder/web/src/lib/device/write.ts
  • builder/web/src/lib/download.ts
  • builder/web/src/lib/format.ts
  • builder/web/src/lib/palette.ts
  • builder/web/src/lib/platform/bundle.test.ts
  • builder/web/src/lib/platform/dev.ts
  • builder/web/src/lib/platform/dev.wire.test.ts
  • builder/web/src/lib/platform/hosts.test.ts
  • builder/web/src/lib/platform/index.ts
  • builder/web/src/lib/platform/types.ts
  • builder/web/src/lib/platform/web.ts
  • builder/web/src/lib/schema/lods.test.ts
  • builder/web/src/lib/schema/lods.ts
  • builder/web/src/lib/schema/previewController.test.ts
  • builder/web/src/lib/schema/previewController.ts
  • builder/web/src/lib/schema/render.ts
  • builder/web/src/lib/ui/confirm.svelte.test.ts
  • builder/web/src/lib/ui/confirm.svelte.ts
  • builder/web/src/lib/usb/objects.ts
  • builder/web/src/lib/usb/protocol.ts
  • builder/web/src/main.ts
  • builder/web/src/pages/Device.svelte
  • builder/web/src/pages/area/outside.ts
  • builder/web/src/routes/Advanced.svelte
  • builder/web/src/routes/Advanced.svelte.test.ts
  • builder/web/src/routes/Home.svelte
  • builder/web/src/styles/app.css
  • builder/web/test-support/coverage/Selection.svelte
  • builder/web/test-support/device-sync/fake-device.ts
  • builder/web/tests/browser/assemble-download.test.js
  • builder/web/tests/browser/basemap-config.json
  • builder/web/tests/browser/basemap-stub.js
  • builder/web/tests/browser/basemap.test.js
  • builder/web/tests/browser/live-memory.test.ts
  • builder/web/tests/browser/package.json
  • builder/web/tests/browser/planner/area.test.js
  • builder/web/tests/browser/playwright.config.js
  • builder/web/tests/browser/playwright.live.config.js
  • builder/web/tsconfig.json
  • builder/web/vite.config.ts
  • docs/build_docs.py
  • docs/content/index.md
  • docs/design/README.md
  • docs/design/device-map-builder.md
  • docs/design/map.json
  • docs/design/web-planner.md
  • docs/index.html
  • docs/testing.md
  • host/obc-bake/tests/test_routing_profiles.py
  • pyproject.toml
  • tools/check_data_sources.py
  • tools/fixture_catalog.py
  • tools/justfile
  • tools/obc.local.example
  • tools/test_plan.py
  • tools/testing/suites.toml
  • tools/tests/test_data_registry.py
  • tools/tests/test_selection_plan.py

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

timohueser and others added 4 commits November 15, 2026 22:20
…-builder-page

# Conflicts:
#	docs/design/README.md
Co-Authored-By: Claude Opus <noreply@anthropic.com>
The local frontend gate no longer calls the deleted build:all; its vitest
step builds the app. The option to keep downloaded map data goes, so each
run clears the work files of the runs before it. The route upload of the
old page, two unused format helpers, saveBytes and the static and log
options of the fixture server go. The 503 base map case checks again that
only the tile host is asked, and false sentences that named the map
builder are correct.

Co-Authored-By: Claude Opus <noreply@anthropic.com>
No run reuses the cells of another, so openCellInventory, the stored-cell
term of the disk projection and their tests go.

Co-Authored-By: Claude Opus <noreply@anthropic.com>
@timohueser
timohueser marked this pull request as ready for review November 15, 2026 21:43
@timohueser
timohueser enabled auto-merge November 15, 2026 21:51
@timohueser
timohueser merged commit c57c562 into develop Nov 15, 2026
28 checks passed
@timohueser
timohueser deleted the claude/3496-delete-builder-page branch November 15, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant