Skip to content

Remove the desktop app - #3403

Merged
timohueser merged 6 commits into
developfrom
claude/3388-remove-desktop-app
Nov 12, 2026
Merged

timohueser merged 6 commits into
developfrom
claude/3388-remove-desktop-app

Conversation

@timohueser

@timohueser timohueser commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Mode: change #3388
Requirements: SYS-015, SYS-019, SYS-070
Public docs: yes

Closes #3388. Part of #3361.

What changed

  • builder/desktop/ is deleted. The Linux udev rule moves to builder/usb/linux/. The new builder/usb/README.md gives its install steps. Chrome on Linux needs the same rule for WebUSB.
  • obc-usb stays for obc format-card. open returns only the link. OpenedLink, device_id, OpenLink::cancel_all, Pipe::max_packet and the serde derives are removed, because no code reads them.
  • The web code that only the desktop host reaches is deleted: 33 source files and 14 test files (the device page, the ride library page, the desktop page, Gated.svelte, gating.ts, lib/desktop/, platform/desktop.ts).
  • Platform loses caps, usbViaWebUsb, rides, openMapOutput and device. DeviceSession loses transport and supported. openWebUsbSession is now openDeviceSession, and DeviceHolder.open loads it with a dynamic import, so the USB stack stays out of the entry chunk.
  • A browser with no WebUSB now shows: "This browser cannot use the USB cable. Use Chrome or Edge."
  • CI loses the jobs desktop-frontend and desktop, the desktop fmt and deny steps, and the desktop-tests-* artifacts. obc-usb now builds in CI on Linux only. The tools, the suites, the justfile, the licences, uv.lock and the data reader desktop app lose their desktop entries. THIRD-PARTY.md is generated again.
  • .claude/launch.json loses the configuration web-builder-desktop.
  • Public docs changed, in their own docs: commit: the privacy pages (English and German), two guide pages, three specs (sentences only), docs/design/device-map-builder.md, docs/testing.md, README.md, AGENTS.md and firmware/README.md. obc cairn map ran again after the merge of develop.

What a visitor of the hosted map builder no longer sees

  • The page #/desktop. A link to it now opens the home page.
  • The footer link "Desktop app".
  • The line in the ride export that says the ride library is in the desktop app.
  • In Safari and Firefox, the disabled Connect button with the desktop-app link. The device step shows the new sentence in its place.

Differences from the plan

  • pipe.ts, DeviceSurfaces.svelte and three comments in firmware/obc-app/src/harness/upload.rs named the desktop app in a form that the grep does not find. I changed them too.
  • LINKS.releases, HOME_ROUTE and router.go lost their last user, so I removed them.
  • The privacy pages also lose the row "Route and tour previews in the web application" and the sentence about the device-overview previews: only the deleted device page drew those previews.
  • web.download.test.ts loses the test that openMapOutput is null. hosts.test.ts keeps one check per host and the style-editor check.
  • test_ci_aggregate.py keeps its two-hop chain with the neutral job names bundle and shell.

Requirements

No approved plan cites an automated test that this change deletes. These three requirements are affected:

  • SYS-015 (Map installation): the statement and the criterion usb-hosts require a desktop application. The manual procedure sys-015-usb-hosts has desktop-app steps.
  • SYS-019 (Transfer speed): the manual procedure sys-019-usb-transfer-rate times a transfer from the desktop app.
  • SYS-070 (Emergency information): the statement names the desktop application. It has no plan.

Checks

Ran, on the merged head:

  • obc test -p obc-usb: 16 passed. obc test -p obc-data: passed.
  • obc exec cargo clippy -p obc-usb --all-targets -- -D warnings: clean.
  • cargo check -p obc-data-steps --all-targets: clean. Clippy of obc-data and obc-data-steps stops in host/obc-pack/src/landmarks/assets.rs:109 (a lint of the local toolchain in a file that this change does not touch).
  • obc check frontend: svelte-check clean, builds pass, vitest 1591 of 1592. The failure is DownloadStep.svelte.test.ts › admits a disk-only rebuild only when cached cells make the quota projection fit: globalThis.localStorage is undefined under the local Node 26. It fails the same way with the component of origin/develop. CI uses Node 22.
  • npm test --prefix builder/web/tests/browser: 4 passed. The first run failed on loopback connection resets; the second run passed.
  • tools/tests (331 tests): passed.
  • obc suites check, obc cairn check (0 new), obc licenses --check, python3 tools/prose.py --check, python3 docs/build_docs.py --check-links: pass.
  • git grep -IiE "tauri|obc-desktop|builder/desktop|desktop.app" -- . ':!planner/tiles/README.md': prints nothing.

Left out: obc test affected --base origin/develop. It selects the whole graph, because ci.yml and tools/test_plan.py changed, which includes the iOS builds and the firmware images. That is more than the time budget, so CI is the gate.

Checks for the owner

  • In Chrome, open /builder/, connect a device, and send a map. Pass: the map arrives on the device.
  • In Safari or Firefox, open /builder/. Pass: the device step shows "This browser cannot use the USB cable. Use Chrome or Edge." and no Connect button.

Review fixes

The code review found more code that only the deleted pages used. These commits remove it:

  • The confirm with three buttons (confirmChoice, extra) and its tests. Its one caller was the deleted device page.
  • The TypeScript codec of trip objects in lib/usb/objects.ts, and routeWaypoints with its bridge export obcr_to_waypoints and their tests. The Swift and Rust trip code of the phone app, the simulators and the firmware stays.
  • vendorIn and siteNav are required now. The error code unavailable, its branch and its test are gone. A new type RecordLink holds the two channels and close; DeviceLink adds vendorIn, and the loopback device end takes a RecordLink.
  • Old desktop text in comments and in two specs. specs/obcc-catalog.md loses the origin rule for a desktop consumer, because the web client does not restrict origins.

The bridge after these commits: 475,259 B gzipped with glue (86 % of the budget), 1,239,153 B raw (91 %).

🤖 Generated with Claude Code

timohueser and others added 3 commits November 12, 2026 16:46
Delete builder/desktop and the web code that only the desktop host
reaches: the device page, the ride library page, the desktop page, the
gating layer and the desktop platform. The hosted map builder keeps the
device step; a browser with no WebUSB now shows "This browser cannot use
the USB cable. Use Chrome or Edge."

obc-usb stays for `obc format-card`. Its `open` returns only the link,
and the Linux udev rule moves to builder/usb/linux with a README.

CI loses the desktop-frontend and desktop jobs, and the tools, suites,
licences and data readers lose their desktop entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-desktop-app

# Conflicts:
#	docs/design/map.json
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 175 files, which is 75 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4bb3a7c6-4147-4f60-a16a-21664a87946e
Commits

Reviewing files that changed from the base of the PR and between 27c7772 and 4d3bb8c.

Files ignored due to path filters: 9

  • Cargo.lock is excluded by !**/*.lock
  • builder/desktop/Cargo.lock is excluded by !**/*.lock
  • builder/desktop/icons/128x128.png is excluded by !**/*.png
  • builder/desktop/icons/128x128@2x.png is excluded by !**/*.png
  • builder/desktop/icons/32x32.png is excluded by !**/*.png
  • builder/desktop/icons/icon.ico is excluded by !**/*.ico
  • builder/desktop/icons/icon.png is excluded by !**/*.png
  • builder/web/package-lock.json is excluded by !**/package-lock.json
  • uv.lock is excluded by !**/*.lock
Files selected for processing: 175

  • .claude/launch.json
  • .github/workflows/bake.yml
  • .github/workflows/ci.yml
  • .github/workflows/deploy-site.yml
  • .gitignore
  • AGENTS.md
  • Cargo.toml
  • README.md
  • builder/__init__.py
  • builder/desktop/.gitignore
  • builder/desktop/Cargo.toml
  • builder/desktop/README.md
  • builder/desktop/build.rs
  • builder/desktop/capabilities/default.json
  • builder/desktop/e2e/launch.py
  • builder/desktop/icons/icon.icns
  • builder/desktop/src/catalog.rs
  • builder/desktop/src/http.rs
  • builder/desktop/src/main.rs
  • builder/desktop/src/map_output.rs
  • builder/desktop/src/paths.rs
  • builder/desktop/src/rides.rs
  • builder/desktop/src/usb/mod.rs
  • builder/desktop/src/usb/runtime_guard.rs
  • builder/desktop/src/usb/watch.rs
  • builder/desktop/tauri.conf.json
  • builder/server/schema_preview.py
  • builder/usb/Cargo.toml
  • builder/usb/README.md
  • builder/usb/linux/99-openbikecomputer.rules
  • builder/usb/src/client/usb.rs
  • builder/usb/src/lib.rs
  • builder/wasm/src/convert.rs
  • builder/wasm/src/convert_web.rs
  • builder/web/package.json
  • builder/web/src/App.svelte
  • builder/web/src/components/ConfirmDialog.svelte
  • builder/web/src/components/DeviceChip.svelte
  • builder/web/src/components/Gated.svelte
  • builder/web/src/components/Header.svelte
  • builder/web/src/components/UpdatePrompt.svelte
  • builder/web/src/components/coverage/CorridorPanel.svelte
  • builder/web/src/components/coverage/CoverageHome.svelte
  • builder/web/src/components/coverage/CoverageHome.svelte.test.ts
  • builder/web/src/components/coverage/DownloadStep.svelte
  • builder/web/src/components/device/CardFormat.svelte
  • builder/web/src/components/device/DeviceStep.svelte
  • builder/web/src/components/device/DeviceSurfaces.svelte
  • builder/web/src/components/device/MapSendStep.svelte
  • builder/web/src/components/device/PopMenu.svelte
  • builder/web/src/components/device/PreviewModal.svelte
  • builder/web/src/components/device/RideExport.svelte
  • builder/web/src/components/device/RideLibrary.svelte
  • builder/web/src/components/device/RideMap.svelte
  • builder/web/src/components/device/RideTiles.svelte
  • builder/web/src/components/device/RouteTiles.svelte
  • builder/web/src/components/device/Tile.svelte
  • builder/web/src/components/device/TrackThumb.svelte
  • builder/web/src/components/device/TripBand.svelte
  • builder/web/src/components/device/TripDropDialog.svelte
  • builder/web/src/lib/catalog/client.test.ts
  • builder/web/src/lib/catalog/client.ts
  • builder/web/src/lib/constants.ts
  • builder/web/src/lib/convert/bridge.test.ts
  • builder/web/src/lib/convert/bridge.ts
  • builder/web/src/lib/desktop/invoke.ts
  • builder/web/src/lib/desktop/library.test.ts
  • builder/web/src/lib/desktop/library.ts
  • builder/web/src/lib/desktop/release.test.ts
  • builder/web/src/lib/desktop/release.ts
  • builder/web/src/lib/desktop/usb.svelte.ts
  • builder/web/src/lib/desktop/usb.test.ts
  • builder/web/src/lib/desktop/usb.ts
  • builder/web/src/lib/device/dashboard.svelte.test.ts
  • builder/web/src/lib/device/dashboard.svelte.ts
  • builder/web/src/lib/device/elevation.test.ts
  • builder/web/src/lib/device/elevation.ts
  • builder/web/src/lib/device/library.test.ts
  • builder/web/src/lib/device/library.ts
  • builder/web/src/lib/device/manage.test.ts
  • builder/web/src/lib/device/manage.ts
  • builder/web/src/lib/device/multidrop.test.ts
  • builder/web/src/lib/device/multidrop.ts
  • builder/web/src/lib/device/progress.ts
  • builder/web/src/lib/device/rideMap.test.ts
  • builder/web/src/lib/device/rideMap.ts
  • builder/web/src/lib/device/rides.ts
  • builder/web/src/lib/device/segments.test.ts
  • builder/web/src/lib/device/segments.ts
  • builder/web/src/lib/device/session.svelte.ts
  • builder/web/src/lib/device/thumbs.svelte.ts
  • builder/web/src/lib/device/thumbs.test.ts
  • builder/web/src/lib/device/tripDelete.test.ts
  • builder/web/src/lib/device/tripDelete.ts
  • builder/web/src/lib/firmware/release.test.ts
  • builder/web/src/lib/platform/bundle.test.ts
  • builder/web/src/lib/platform/desktop.ts
  • builder/web/src/lib/platform/desktop.wire.test.ts
  • builder/web/src/lib/platform/dev.ts
  • builder/web/src/lib/platform/dev.wire.test.ts
  • builder/web/src/lib/platform/gating.test.ts
  • builder/web/src/lib/platform/gating.ts
  • builder/web/src/lib/platform/hosts.test.ts
  • builder/web/src/lib/platform/index.ts
  • builder/web/src/lib/platform/types.ts
  • builder/web/src/lib/platform/web.download.test.ts
  • builder/web/src/lib/platform/web.ts
  • builder/web/src/lib/router.svelte.ts
  • builder/web/src/lib/routes.ts
  • builder/web/src/lib/ui/confirm.svelte.test.ts
  • builder/web/src/lib/ui/confirm.svelte.ts
  • builder/web/src/lib/ui/menu.ts
  • builder/web/src/lib/usb/client.test.ts
  • builder/web/src/lib/usb/client.ts
  • builder/web/src/lib/usb/errors.ts
  • builder/web/src/lib/usb/flat-device.ts
  • builder/web/src/lib/usb/loopback.ts
  • builder/web/src/lib/usb/objects.ts
  • builder/web/src/lib/usb/pipe.ts
  • builder/web/src/lib/usb/session.svelte.ts
  • builder/web/src/lib/usb/session.ts
  • builder/web/src/lib/usb/webusb.test.ts
  • builder/web/src/lib/usb/webusb.ts
  • builder/web/src/routes/Advanced.svelte
  • builder/web/src/routes/Desktop.svelte
  • builder/web/src/routes/Device.svelte
  • builder/web/src/routes/Rides.svelte
  • builder/web/test-support/data/review.json
  • builder/web/test-support/data/run-planned.json
  • builder/web/test-support/data/status.json
  • builder/web/tsconfig.json
  • builder/web/vite.config.ts
  • builder/web/vite/third-party-licenses.ts
  • docs/content/datenschutz.md
  • docs/content/privacy.md
  • docs/content/software/formats.md
  • docs/content/software/packer-routing.md
  • docs/design/README.md
  • docs/design/device-map-builder.md
  • docs/design/map.json
  • docs/testing.md
  • firmware/README.md
  • firmware/obc-app/src/harness/upload.rs
  • firmware/obc-fw-nrf54l/src/usb/mod.rs
  • firmware/tools/dependency_rules.json
  • host/obc-bake/src/bin/obc-pack.rs
  • host/obc-bake/src/lib.rs
  • host/obc-bake/src/pipeline.rs
  • host/obc-bake/tests/packer_cases/pipeline.rs
  • host/obc-data-steps/src/device/catalog.rs
  • host/obc-data-steps/src/readers.rs
  • host/obc-data/README.md
  • host/obc-data/src/cli/serve_cli.rs
  • host/obc-draw/src/land.rs
  • host/obc-map-core/src/progress.rs
  • pyproject.toml
  • specs/flat-store-protocol.md
  • specs/obca-assembly.md
  • specs/obcc-catalog.md
  • tools/fixture_catalog.py
  • tools/install-geos.sh
  • tools/justfile
  • tools/licenses/THIRD-PARTY.md
  • tools/licenses/deny.toml
  • tools/licenses/gen-third-party.sh
  • tools/obc.bash
  • tools/ready.py
  • tools/test_plan.py
  • tools/testing/prose-baseline.json
  • tools/testing/suites.toml
  • tools/tests/test_ci_aggregate.py
  • tools/tests/test_ready.py
  • tools/tests/test_selection_plan.py
  • tools/verification/ops/download_reports.py
  • tools/verification/ops/import_results.py

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

timohueser and others added 2 commits November 12, 2026 17:18
Delete the three-way confirm, the TypeScript trip codec, and the OBCR
waypoint reader with its wasm export. `vendorIn` and `siteNav` are now
required, so the "unavailable" error and the header without site links
go. The device end of the loopback link is a `RecordLink`. Comments no
longer name the desktop app.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@timohueser
timohueser marked this pull request as ready for review November 12, 2026 16:19
@timohueser
timohueser enabled auto-merge November 12, 2026 18:03
@timohueser
timohueser merged commit 13bcb25 into develop Nov 12, 2026
28 checks passed
@timohueser
timohueser deleted the claude/3388-remove-desktop-app branch November 12, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the desktop app

1 participant