Repository navigation
Remove the desktop app - #3403
Merged
Merged
Conversation
Delete builder/desktop and the web code that only the desktop host reaches: the device page, the ride library page, the desktop page, the gating layer and the desktop platform. The hosted map builder keeps the device step; a browser with no WebUSB now shows "This browser cannot use the USB cable. Use Chrome or Edge." obc-usb stays for `obc format-card`. Its `open` returns only the link, and the Linux udev rule moves to builder/usb/linux with a README. CI loses the desktop-frontend and desktop jobs, and the tools, suites, licences and data readers lose their desktop entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-desktop-app # Conflicts: # docs/design/map.json
Contributor
|
Important Review skippedToo many files! This PR contains 175 files, which is 75 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
Delete the three-way confirm, the TypeScript trip codec, and the OBCR waypoint reader with its wasm export. `vendorIn` and `siteNav` are now required, so the "unavailable" error and the header without site links go. The device end of the loopback link is a `RecordLink`. Comments no longer name the desktop app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
timohueser
marked this pull request as ready for review
November 12, 2026 16:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mode: change #3388
Requirements: SYS-015, SYS-019, SYS-070
Public docs: yes
Closes #3388. Part of #3361.
What changed
builder/desktop/is deleted. The Linux udev rule moves tobuilder/usb/linux/. The newbuilder/usb/README.mdgives its install steps. Chrome on Linux needs the same rule for WebUSB.obc-usbstays forobc format-card.openreturns only the link.OpenedLink,device_id,OpenLink::cancel_all,Pipe::max_packetand the serde derives are removed, because no code reads them.Gated.svelte,gating.ts,lib/desktop/,platform/desktop.ts).Platformlosescaps,usbViaWebUsb,rides,openMapOutputanddevice.DeviceSessionlosestransportandsupported.openWebUsbSessionis nowopenDeviceSession, andDeviceHolder.openloads it with a dynamic import, so the USB stack stays out of the entry chunk.desktop-frontendanddesktop, the desktop fmt and deny steps, and thedesktop-tests-*artifacts.obc-usbnow builds in CI on Linux only. The tools, the suites, the justfile, the licences,uv.lockand the data readerdesktop applose their desktop entries.THIRD-PARTY.mdis generated again..claude/launch.jsonloses the configurationweb-builder-desktop.docs:commit: the privacy pages (English and German), two guide pages, three specs (sentences only),docs/design/device-map-builder.md,docs/testing.md,README.md,AGENTS.mdandfirmware/README.md.obc cairn mapran again after the merge ofdevelop.What a visitor of the hosted map builder no longer sees
#/desktop. A link to it now opens the home page.Differences from the plan
pipe.ts,DeviceSurfaces.svelteand three comments infirmware/obc-app/src/harness/upload.rsnamed the desktop app in a form that the grep does not find. I changed them too.LINKS.releases,HOME_ROUTEandrouter.golost their last user, so I removed them.web.download.test.tsloses the test thatopenMapOutputis null.hosts.test.tskeeps one check per host and the style-editor check.test_ci_aggregate.pykeeps its two-hop chain with the neutral job namesbundleandshell.Requirements
No approved plan cites an automated test that this change deletes. These three requirements are affected:
usb-hostsrequire a desktop application. The manual proceduresys-015-usb-hostshas desktop-app steps.sys-019-usb-transfer-ratetimes a transfer from the desktop app.Checks
Ran, on the merged head:
obc test -p obc-usb: 16 passed.obc test -p obc-data: passed.obc exec cargo clippy -p obc-usb --all-targets -- -D warnings: clean.cargo check -p obc-data-steps --all-targets: clean. Clippy ofobc-dataandobc-data-stepsstops inhost/obc-pack/src/landmarks/assets.rs:109(a lint of the local toolchain in a file that this change does not touch).obc check frontend: svelte-check clean, builds pass, vitest 1591 of 1592. The failure isDownloadStep.svelte.test.ts › admits a disk-only rebuild only when cached cells make the quota projection fit:globalThis.localStorageis undefined under the local Node 26. It fails the same way with the component oforigin/develop. CI uses Node 22.npm test --prefix builder/web/tests/browser: 4 passed. The first run failed on loopback connection resets; the second run passed.tools/tests(331 tests): passed.obc suites check,obc cairn check(0 new),obc licenses --check,python3 tools/prose.py --check,python3 docs/build_docs.py --check-links: pass.git grep -IiE "tauri|obc-desktop|builder/desktop|desktop.app" -- . ':!planner/tiles/README.md': prints nothing.Left out:
obc test affected --base origin/develop. It selects the whole graph, becauseci.ymlandtools/test_plan.pychanged, which includes the iOS builds and the firmware images. That is more than the time budget, so CI is the gate.Checks for the owner
/builder/, connect a device, and send a map. Pass: the map arrives on the device./builder/. Pass: the device step shows "This browser cannot use the USB cable. Use Chrome or Edge." and no Connect button.Review fixes
The code review found more code that only the deleted pages used. These commits remove it:
confirmChoice,extra) and its tests. Its one caller was the deleted device page.lib/usb/objects.ts, androuteWaypointswith its bridge exportobcr_to_waypointsand their tests. The Swift and Rust trip code of the phone app, the simulators and the firmware stays.vendorInandsiteNavare required now. The error codeunavailable, its branch and its test are gone. A new typeRecordLinkholds the two channels andclose;DeviceLinkaddsvendorIn, and the loopback device end takes aRecordLink.specs/obcc-catalog.mdloses the origin rule for a desktop consumer, because the web client does not restrict origins.The bridge after these commits: 475,259 B gzipped with glue (86 % of the budget), 1,239,153 B raw (91 %).
🤖 Generated with Claude Code