Skip to content

foundations: fix the small findings of #3363 - #3365

Merged
timohueser merged 5 commits into
developfrom
claude/3363-foundations-fixes
Nov 11, 2026
Merged

timohueser merged 5 commits into
developfrom
claude/3363-foundations-fixes

Conversation

@timohueser

Copy link
Copy Markdown
Owner

Mode: fix
Requirements: none
Public docs: yes (the architecture guide, in its own docs: commit)

This pull request fixes the findings with the action fix in #3363. It changes no behavior and no bytes.

What changes

  • Dependency guard. check_closed_dependencies in firmware/tools/check_dependencies.py refuses a production dependency of the five foundation crates other than heapless, libm and each other. Its list is closed_dependencies in dependency_rules.json. A name in the list that is not in the workspace also fails. CI runs it in the existing dependency-direction step. The Rules table of docs/design/foundations.md cites it.
  • ContentRef codec. The landmarks codec is pub(crate). The article and peak records use it in place of their own copies.
  • CRC. Crc32::checksum is gone. Its 3 callers, all in obc-storage, use crc32.
  • Rename. obc_formats::assistant is now obc_formats::navigator, because it holds the Navigator checkpoint codec. The code-authority path in specs/ride-archive-metadata.md follows. No byte changes.
  • Comments. The waypoint category comments in obcr.rs and obc-route/src/reader.rs now say what the readers do: every PoiCategory id reads as its category. The to_unix doc says where the u32 wraps. Two comments no longer state version history.
  • Docs. The architecture guide lists the five foundation crates. The foundations doc records why Cue is in obc-ports.

Checks that ran

  • cargo test for obc-crc (5), obc-formats (51), obc-ports, obc-storage (193) and obc-app: all passed.
  • cargo clippy --all-targets -- -D warnings for the same crates; clippy --lib -D warnings for obc-route and obc-host-core.
  • cargo fmt --all, and cargo fmt in firmware/obc-fw-nrf54l.
  • cairn check: 56 violations, all in the baseline, 0 new.
  • check_dependencies.py and its unit tests; obc suites check; prose.py --check; build_docs.py --check-links.

Checks that did not run

  • The tests of obc-route and obc-host-core, and --all-targets clippy for them: GEOS is not installed. A grep finds no remaining obc_formats::assistant.
  • The board release build: its build script needs a RISC-V gcc. The board changes are two use paths. CI's embedded job builds the board.
  • The flash test. It will run on the board after this pull request and rendering-display: cut the unused generic display contracts #3356 merge, as one combined test.

Notes for review

  • dependency_rules.json already has a foundation group that is not the same set: it has obc-elevation and obc-link, and not obc-file-source. That group sets the direction of dependencies between layers; the new list is the cairn system. I kept them apart in this pull request.
  • specs/obcr-route.md:204 says that a waypoint category outside 1..=6 renders as generic. The readers accept every PoiCategory id. The spec is unchanged here; the owner decides which side is right.

Findings: #3363


Generated by Claude Code

check_dependencies.py now reads a closed crate list from dependency_rules.json: the five
foundation crates take only heapless, libm and each other as production dependencies. The
foundations design doc cites the check and records why the sound cue crosses the port.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011wmjvKzamiTf3Th8ePmUoi
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011wmjvKzamiTf3Th8ePmUoi
…ments

The module holds the Navigator checkpoint codec. The waypoint category comment now says what
readers do: every OBCM PoiCategory id reads as that category. DateTime::to_unix states where
its u32 wraps. Version-history wording is gone from obcr.rs and cache.rs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011wmjvKzamiTf3Th8ePmUoi
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copy link
Copy Markdown
Owner Author

The desktop (ubuntu-24.04, linux-x86_64, obc-desktop) job failed in its apt-get install step. The runner could not resolve azure.archive.ubuntu.com ("Temporary failure resolving"), so it could not fetch four libsoup-3.0 packages. The job stopped before it built or tested any code. This pull request does not touch the desktop app or the workflow, so the failure is not caused by this pull request. GitHub refuses a re-run while the workflow still runs. I will re-run the failed job once when the run ends.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

The wasm job failed for the same reason as desktop: the Playwright browser install could not fetch font packages, because the runner could not resolve azure.archive.ubuntu.com. The browser journey then did not run. Every other job of the run passed. I re-ran the failed jobs (wasm, desktop and the ci summary) once.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

The re-run of desktop (ubuntu-24.04, …) failed again in apt-get install, with the same "Temporary failure resolving 'azure.archive.ubuntu.com'". It is not this pull request: #3357 changes only the routing bake, and its run failed the same two jobs (desktop (ubuntu-24.04, …) and wasm) between 16:01 and 16:05 UTC. The Ubuntu mirror of the GitHub runners is not reachable now. No fix exists in this repository. I will not re-run again until the mirror works.


Generated by Claude Code

@timohueser
timohueser marked this pull request as ready for review November 11, 2026 18:22
@timohueser
timohueser merged commit a98ff2e into develop Nov 11, 2026
84 of 90 checks passed
@timohueser
timohueser deleted the claude/3363-foundations-fixes branch November 11, 2026 18:23
@github-actions github-actions Bot mentioned this pull request Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants