Skip to content

TrailView ground plan: two edges that cross each other beside a cell line in one cell only #3355

Closed

Description

@timohueser

Status: proposed

Part of #3096. One small pull request into ground-plan. Found in the review of #3354 (water-pickup/REVIEW-3354.md on timosPC, finding N2). Short name: gp/ = host/obc-ground-plan/src/.

Goal

Two neighbouring cells give the same faces on their shared line also where two edges cross each other within one unit of that line, in one cell only. This is the torn-face class of fault (check 2 of tests/faces.rs).

The case

  • ground plan: rings and seams get a vertex at each tile line by one global rule #3354 makes every tile-line point a vertex that both cells compute alike, and a point that one cell holds alone never lies on a cell line. One case stays open: the crossing of two edges that the overlay computes inside one cell.
  • An edge that only one cell holds stays at least 2 units off the cell line (snap in gp/faces/mod.rs puts every nearer vertex on the line). So the open case is two edges that both end on the cell line, at points 4 or more units apart (closer points merge_crossings joins), and that cross each other less than one unit from the line.
  • Example (local to the east cell): e1 from (0, y) to (68, y + 3450), e2 from (0, y + 4) to (68, y − 3446). They cross at (0.04, y + 2). The east tile rounds that point to (0, y + 2), on the cell line. The east cell loses the wedge on [y, y + 4]; the west cell keeps it. The fault is 4 units (6 mm) long.
  • It needs one edge within about 14° of the cell line. The fixtures show 0 faults, so there is no measured rate.

The rule (proposal of the review)

Make the test of merge_crossings match its doc ("Two edges that cross each other beside a cell line then cross on it"). Two neighbouring crossings on a cell line also merge when their edges into the cell meet within MERGE units of the line, by an exact i128 test, not only when they lie closer than MERGE along the line. Neighbouring pairs are sufficient: a third edge that starts between two edges must leave their wedge through one of them, nearer the line.

Proof

  • A unit test with the example above and its mirror: the two windows give the same faces on the line.
  • tests/faces.rs and tests/records.rs on the fixture: 0 faults. Plan digests before | after.

Requirements: none


Generated by Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions